Use a StagingBelt in iced_wgpu for regular buffer uploads
#2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
force-pushed
the
wgpu/use-staging-belt
branch
from
851e94e
to
d11e271
Compare
hecrj
added a commit
to hecrj/glyphon
that referenced
this pull request
Mar 30, 2024
`Queue::write_buffer` allocates very regularly, specially on Metal. See: iced-rs/iced#2357 A `StagingBelt` gives us more control and predictability.
hecrj
added a commit
to hecrj/glyphon
that referenced
this pull request
Mar 30, 2024
`Queue::write_buffer` allocates very regularly, specially on Metal. See: iced-rs/iced#2357 A `StagingBelt` gives us more control and predictability.
hecrj
added a commit
to hecrj/glyphon
that referenced
this pull request
Mar 30, 2024
`Queue::write_buffer` allocates very regularly, specially on Metal. See: iced-rs/iced#2357 A `StagingBelt` gives us more control and predictability.
grovesNL
pushed a commit
to hecrj/glyphon
that referenced
this pull request
May 27, 2024
`Queue::write_buffer` allocates very regularly, specially on Metal. See: iced-rs/iced#2357 A `StagingBelt` gives us more control and predictability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue::write_bufferseems to be allocating new buffers often, at least on Metal.Flamegraph of
game_of_lifebefore:Flamegraph of
game_of_lifeafter: