Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis class #644

Open
philippeller opened this issue Oct 14, 2020 · 1 comment
Open

Analysis class #644

philippeller opened this issue Oct 14, 2020 · 1 comment
Labels
enhancement good first issue help wanted streamlining

Comments

@philippeller
Copy link
Collaborator

Current analysis class is overly complicated with 2k+ SLOCs and nested function calls that I cannot really see through....
Simpler >> Complicated
@philippeller philippeller mentioned this issue Mar 15, 2021
Open
@JanWeldert
Copy link
Contributor

Adding to this, the analysis.py script is also much too long with more than 3.5 k lines. Since it contains multiple classes and helper functions, splitting it up in different files (all located in pisa/analysis) should not be too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted streamlining
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philippeller @JanWeldert