Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to re-enter credentials even when jsessionid is available. #15

Closed
danielvandenberg95 opened this issue Dec 26, 2020 · 3 comments
Closed

Comments

@danielvandenberg95
Copy link
Collaborator

I'd like to not prompt my users for username/password if there's still a jsessionid available. However, there's currently an explicit check to verify that an username and password are given.

Is there a reason this check exists (as I'm assuming degiro would check this server-side too), or is it double?

Should the check be removed, stay in place (for a reason unknown to me) and have documentation added, or can the check be wrapped in a if (!this.jsessionId)?

@magnific0
Copy link
Contributor

magnific0 commented Jan 29, 2021

@danielvandenberg95 this is fixed this in #21 and in the newest version on npm (v1.0.3).

Any smart prompting should probably take place on the application level, but the library now requires either username/password to be set OR a jsessionid.

I'm new to this library and degiro. So in your experience, how long do jsessionids remain valid. Can you refresh them?

@icastillejogomez
Copy link
Owner

@magnific0 Do we close this issue then?

@magnific0
Copy link
Contributor

@icastillejogomez sounds fine with me. I assume @danielvandenberg95 took note, so let's call it resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants