You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd like to not prompt my users for username/password if there's still a jsessionid available. However, there's currently an explicit check to verify that an username and password are given.
Is there a reason this check exists (as I'm assuming degiro would check this server-side too), or is it double?
Should the check be removed, stay in place (for a reason unknown to me) and have documentation added, or can the check be wrapped in a if (!this.jsessionId)?
The text was updated successfully, but these errors were encountered:
@danielvandenberg95 this is fixed this in #21 and in the newest version on npm (v1.0.3).
Any smart prompting should probably take place on the application level, but the library now requires either username/password to be set OR a jsessionid.
I'm new to this library and degiro. So in your experience, how long do jsessionids remain valid. Can you refresh them?
I'd like to not prompt my users for username/password if there's still a jsessionid available. However, there's currently an explicit check to verify that an username and password are given.
Is there a reason this check exists (as I'm assuming degiro would check this server-side too), or is it double?
Should the check be removed, stay in place (for a reason unknown to me) and have documentation added, or can the check be wrapped in a
if (!this.jsessionId)
?The text was updated successfully, but these errors were encountered: