Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast horizon = 0 #554

Closed
javiarrobas opened this issue Jul 5, 2023 · 3 comments · Fixed by #558
Closed

Forecast horizon = 0 #554

javiarrobas opened this issue Jul 5, 2023 · 3 comments · Fixed by #558

Comments

@javiarrobas
Copy link
Contributor

In this line we prevent from forecast horizons of 0. Fundamentally, that makes sense. However, the only way for a user to get to know current boundary condition data other than weather is by using the forecaster with a prediction horizon of 0. In the case of weather data, we have the weather station block, but there are others like pricing or setpoints that couldn't be retrieved for the current time otherwise. A use case can be e.g. a PI controller that reacts to deviations from a setpoint, or a reinforcement learning agent that includes current setpoints and pricing in its observation space. I therefore suggest to change the <= of that line to <.

@dhblum
Copy link
Collaborator

dhblum commented Jul 11, 2023

I agree that there is need for the use cases you mention and this seems like a simple implementation that uses existing API. Care to make a PR?

@javiarrobas
Copy link
Contributor Author

Sure! sent it #558.

@dhblum
Copy link
Collaborator

dhblum commented Jul 20, 2023

Closed by #559.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants