Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After moving to use native promises, getting JS errors in the console from some successful unit tests. #65

Open
edchat opened this issue Jan 28, 2015 · 0 comments
Assignees

Comments

@edchat
Copy link
Contributor

edchat commented Jan 28, 2015

After moving to use "requirejs-dplugins/Promise!" instead of always using lie promises, began getting JS errors in the console from some successful unit tests. Lie promises must have been hiding these errors.
These tests are seeing the errors:
multipleAndNestedViewsActivateCallsSuite1: - test multiple and nested Views activation calls

multipleAndNestedViewsActivateCallsConstraintsSuite1: testApp.showOrHideViews('contentCons,P2,P2S1,P2V2') will show P2,P2S1,P2V2

historyControllerSuite1: show hc1left2 - testApp.showOrHideViews('hc1leftParent,hc1left2' with parent and child params)

The error is an unhandled promise rejection, and it seems to be caused by code in Container.insertBefore trying to add a child of null.

Need to figure out how dapp is returning a null child, and/or there should probably be a check for null before trying to add the node in DisplayContainer.show() before calling self.addChild(value.child, value.index);

@edchat edchat self-assigned this Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant