[Discounts] Event reference #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview of modified filesPreview of modified Markdown: |
konradoboza
approved these changes
Jun 10, 2025
ezrobot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
julitafalcondusza
approved these changes
Jun 11, 2025
mnocon
added a commit
that referenced
this pull request
Jun 11, 2025
* [Discounts] Added event reference * Fixed links * Fixes before review * Removed column
mnocon
added a commit
that referenced
this pull request
Jun 11, 2025
* [Discounts] Added event reference * Fixed links * Fixes before review * Removed column
mnocon
added a commit
that referenced
this pull request
Jun 11, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 11, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Described Twig Components --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Added Twig reference * Self review * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Added Twig reference * Self review * [Discounts] Release notes * Added mention about the update --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Described Twig Components --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Added Twig reference * Self review * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
mnocon
added a commit
that referenced
this pull request
Jun 13, 2025
* [PHP API] Discounts (#2763) * [PHP API REF] Added Discount packages * Generated PHP API for Discounts * Discount product guide * Fixed links and navigation * Removed nav * Fixed links * Fixed typo * Fixed badges * Removed whitespace * Fixes before review * After review fixes * Currency remark * Discount migrations (#2768) * [Discounts] Added migration doc * Added files * Update docs/content_management/data_migration/importing_data.md * Applied suggestions from code review (#2767) Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Search overview (#2773) * [Discounts] Search overview * Fixes before review * Reworded Type sort clause * Update docs/search/discounts_search_reference/discounts_sort_clauses.md Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * [Discounts] Event reference (#2776) * [Discounts] Added event reference * Fixed links * Fixes before review * Removed column * [Discounts] Mentioned discounts in pricing and customer groups (#2775) * Mentioned discounts in pricing and customer groups * Before review fixes * Added mention to the PIM guide * [Discounts] Discount policies (#2771) * Permissions * Build fixes * Fixed links * Fixed last links * Removed link * Apply suggestions from code review Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com> * Discounts update (#2774) * Added update instructions * Fixed link * [Discounts] Added Twig reference * Self review * [Discounts] Release notes * Added mention about the update --------- Co-authored-by: julitafalcondusza <117284672+julitafalcondusza@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For step form events I've used the description from https://github.com/ibexa/discounts/pull/147
I plan to show an example how this can be used in practice when creating the "Extending Discounts" doc, but this will come as a follow-up PR.
Preview: