Skip to content

IBX-8686: Ibexa Commerce Product Guide added in Developer Documentation #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 23, 2024

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Aug 6, 2024

Question Answer
JIRA Ticket IBX-8686
Versions master, 4.6+

Ibexa Commerce Product Guide added in Developer Documentation

Preview: https://ez-systems-developer-documentation--2460.com.readthedocs.build/en/2460/ibexa_products/ibexa_commerce/

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Added link to this PR in relevant JIRA ticket or code PR

@julitafalcondusza julitafalcondusza marked this pull request as ready for review August 12, 2024 13:08
#### Merchandizing

Merchandizing assists in keeping the consistency of the brand and providing customized product recommendations with captivating visuals and powerful search features.
With this feature you can engage your customers with eye-catching graphics and information
Copy link
Contributor

@mnocon mnocon Aug 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
With this feature you can engage your customers with eye-catching graphics and information
With this feature, you can engage your customers with eye-catching graphics and information.

There's no break between these sentences in the preview:
Zrzut ekranu 2024-08-13 o 11 41 20

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a requirement.

Copy link
Contributor

@mnocon mnocon Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean - surely this can't be the desired outcome?
Zrzut ekranu 2024-08-14 o 09 06 28

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was regarding breaks in the preview.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, my comment was only about the missing divide between these two sentences - either adding dot or a line break is good enough for me.

Please note that Tomek also suggests adding a comma into this sentence

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great!

I've only marked a couple of small mistakes (mostly typos)

@julitafalcondusza julitafalcondusza merged commit dd9e2ab into master Aug 23, 2024
5 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-8686 branch August 23, 2024 11:37
julitafalcondusza added a commit that referenced this pull request Aug 26, 2024
…on (#2460)

* Ibexa Commerce product guide added

* Content added

* Content added, sentence moved

* Content added

* Link removed

* Conflicts solved

* Fixes after rev - first batch

* Fixes

* Typo fix

* Fixes after re-rev
adriendupuis added a commit that referenced this pull request Feb 15, 2025
@adriendupuis adriendupuis mentioned this pull request Feb 17, 2025
7 tasks
adriendupuis added a commit that referenced this pull request Feb 19, 2025
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138
adriendupuis added a commit that referenced this pull request Feb 19, 2025
* rm docs/administration/img/admin_panel.png

Unused since #1920

* rm docs/content_management/img/access_focus_mode_PB.png

Never used since #2219

* rm docs/content_management/img/elements_toolbar.png

Not used since #2487

* rm docs/content_management/img/exit_focus_mode.png

Never used since #2219

* rm docs/content_management/images/img/fastly_variations.png

- …/images/img/… from #1864
- Duplicated to a better dir in #2487

* rm content_management/img/page_builder_….png

Several not used files from #2171

* rm docs/getting_started/img/ibexa_cloud_login.png

Never used from #2418

* rm docs/ibexa_products/img/ecommerce.png

Never used from #2460

* rm docs/pim/img/product_completeness.png

Not used anymore since #2232

* rm docs/pim/img/product_variants.png

Never used since #2138

(cherry picked from commit 21d66a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants