Skip to content

IBX-7565: Custom block's UDW config (4.x) #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 3, 2024
Merged

IBX-7565: Custom block's UDW config (4.x) #2331

merged 10 commits into from
Apr 3, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 12, 2024 •
edited
Loading

Question Answer
JIRA Ticket IBX-7565
Versions 4.6, 4.5
Edition Experience, Commerce

Config Universal Discovery Widget for custom block config/edit.

Inspired by #2275

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis mentioned this pull request Mar 12, 2024
Closed
7 tasks
@adriendupuis adriendupuis changed the title Custom block: UDW config IBX-7565: Custom block's UDW config Mar 12, 2024
adriendupuis
adriendupuis commented Mar 13, 2024
View reviewed changes
@adriendupuis
Update docs/content_management/pages/page_block_attributes.md
e0793ef
@adriendupuis
create_custom_page_block.md: Fix link to UDW conf
0145104 
Fix "INFO    -  Doc file 'content_management/pages/create_custom_page_block.md' contains an unrecognized relative link 'browser/#udw-configuration', it was left as is."
@adriendupuis
create_custom_page_block.md: details UDW override
b6f0bf7
@adriendupuis adriendupuis marked this pull request as ready for review March 13, 2024 08:28
@adriendupuis adriendupuis requested a review from vidarl March 13, 2024 08:29
vidarl
vidarl requested changes Mar 14, 2024
View reviewed changes
@adriendupuis @vidarl
Apply suggestions from code review
e967ab2 
Co-authored-by: Vidar <vl@ez.no>
@adriendupuis adriendupuis requested a review from vidarl March 14, 2024 07:52
@adriendupuis adriendupuis requested a review from mnocon March 14, 2024 10:51
mnocon
mnocon approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 🎉

One small thing: there's an additional quote in the code_samples/page/custom_page_block/config/packages/page_blocks.yaml file, could you please fix it as well? See screenshot below.

Screenshot 2024-04-03 at 08 39 09

@adriendupuis adriendupuis added Ready for MERGE Wait with merge PRs that shouldn't be merged instantly and removed Needs DOC review labels Apr 3, 2024
adriendupuis and others added 2 commits April 3, 2024 10:05
@adriendupuis @mnocon
Apply suggestions from code review
1be01ab 
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
@adriendupuis
Update create_custom_page_block.md
5c6be6a
@adriendupuis adriendupuis removed the Wait with merge PRs that shouldn't be merged instantly label Apr 3, 2024
@adriendupuis
Merge branch 'master' into IBX-7565_custom_block_udw_4
f22d3d9 
# Conflicts:
#	docs/content_management/pages/create_custom_page_block.md
@adriendupuis adriendupuis merged commit 375ad0d into master Apr 3, 2024
@adriendupuis adriendupuis deleted the IBX-7565_custom_block_udw_4 branch April 3, 2024 10:48
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis @vidarl @mnocon
IBX-7565: Custom block's UDW config (#2331)
d02aba7 
* create_custom_page_block.md: Custom UDW

---------

Co-authored-by: Vidar <vl@ez.no>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
(cherry picked from commit 375ad0d)
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis @vidarl @mnocon
IBX-7565: Custom block's UDW config (#2331)
3e7fbb2 
* create_custom_page_block.md: Custom UDW

---------

Co-authored-by: Vidar <vl@ez.no>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
(cherry picked from commit 375ad0d)
adriendupuis added a commit that referenced this pull request Apr 3, 2024
@adriendupuis @vidarl @mnocon
IBX-7565: Custom block's UDW config (#2331)
4fec6f3 
* create_custom_page_block.md: Custom UDW

---------

Co-authored-by: Vidar <vl@ez.no>
Co-authored-by: Marek Nocoń <mnocon@users.noreply.github.com>
(cherry picked from commit 375ad0d)
@adriendupuis adriendupuis mentioned this pull request Apr 3, 2024
Merged
7 tasks
@adriendupuis adriendupuis changed the title IBX-7565: Custom block's UDW config IBX-7565: Custom block's UDW config (4.x) Apr 3, 2024
@mnocon mnocon mentioned this pull request Apr 24, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidarl vidarl vidarl approved these changes

@mnocon mnocon mnocon approved these changes

Assignees
No one assigned
Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriendupuis @vidarl @mnocon