Skip to content

Fix baseUri scheme related error #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix baseUri scheme related error #2288

merged 1 commit into from
Feb 12, 2024

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Feb 8, 2024

Question Answer
JIRA Ticket
Versions
Edition

Since #1931 and PHP 8, an error occurs when building HTML:

PHP Deprecated:  mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813

The patch avoid having the error on a relative baseUri like ours.

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

Since (#1931) and PHP 8, an error occurs when raml2html extracts baseUri scheme.

PHP Deprecated:  mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813
@adriendupuis adriendupuis requested a review from adamwojs February 8, 2024 11:04
@adriendupuis adriendupuis merged commit 1745096 into master Feb 12, 2024
@adriendupuis adriendupuis deleted the raml-baseuri branch February 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant