Skip to content

REST API Reference Ibexa logo links back to parent doc. #1931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Mar 21, 2023

Question Answer
JIRA Ticket N/A
Versions 4.x, 3.3
Edition All
  • Change Ibexa logo link behavior
  • Remove ez-raml version number (not displayed and not kept up-to-date, see RAML doc for an example of version usage not followed here)
  • Update Ibexa logo <img> tag alt attribute.

Inspired by its PHP API Reference counter-part d9ef4ba

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis
Copy link
Contributor Author

adriendupuis commented Oct 17, 2023

Note: Since #1871, with PHP 8.1+, the raml2html script output on terminal a Deprecated warning which I fix in raml-org/raml-php-parser#181. Despite this warning, outputted rest_api_reference.html is correct. It could be due to a misusage of baseUri as it seems dedicated to an online API. But, the warning occurs even when no baseUri is defined, so, no need to respect its usage.

@adriendupuis adriendupuis merged commit b020b08 into master Oct 17, 2023
@adriendupuis adriendupuis deleted the rest-api-ref-logo-link branch October 17, 2023 15:26
adriendupuis added a commit that referenced this pull request Oct 17, 2023
* REST API Ref: Ibexa logo links back to doc site
* ez-raml: Remove version as unused and not kept up-to-date

(cherry picked from commit b020b08)
adriendupuis added a commit that referenced this pull request Oct 17, 2023
* REST API Ref: Ibexa logo links back to doc site
* ez-raml: Remove version as unused and not kept up-to-date

(cherry picked from commit b020b08)
adriendupuis added a commit that referenced this pull request Oct 17, 2023
* REST API Ref: Ibexa logo links back to doc site
* ez-raml: Remove version as unused and not kept up-to-date

(cherry picked from commit b020b08)
adriendupuis added a commit that referenced this pull request Feb 8, 2024
Since (#1931) and PHP 8, an error occurs when raml2html extracts baseUri scheme.

PHP Deprecated:  mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813
adriendupuis added a commit that referenced this pull request Feb 12, 2024
Since (#1931) and PHP 8, an error occurs when raml2html extracts baseUri scheme.

PHP Deprecated:  mb_strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated in tools/raml2html/vendor/raml-org/raml-php-parser/src/ApiDefinition.php on line 813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants