Skip to content

Commit b2101d2

Browse files
mnoconViniTou
andauthored
Add missing return types (#2734)
* Added missing return types to code samples * Update code_samples/api/rest_api/src/Rest/InputParser/GreetingInput.php Co-authored-by: Dawid Parafiński <dawid.parafinski@ez.no> --------- Co-authored-by: Dawid Parafiński <dawid.parafinski@ez.no>
1 parent a6897eb commit b2101d2

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

code_samples/api/rest_api/src/Rest/InputParser/GreetingInput.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
class GreetingInput extends BaseParser
1111
{
12-
public function parse(array $data, ParsingDispatcher $parsingDispatcher)
12+
public function parse(array $data, ParsingDispatcher $parsingDispatcher): Greeting
1313
{
1414
if (!isset($data['Salutation'])) {
1515
throw new Exceptions\Parser("Missing or invalid 'Salutation' element for Greeting.");

code_samples/api/rest_api/src/Rest/ValueObjectVisitor/RestLocation.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function __construct(URLAliasService $urlAliasService)
1717
$this->urlAliasService = $urlAliasService;
1818
}
1919

20-
public function visit(Visitor $visitor, Generator $generator, $data)
20+
public function visit(Visitor $visitor, Generator $generator, $data): void
2121
{
2222
// Not using $generator->startObjectElement to not have the XML Generator adding its own media-type attribute with the default vendor
2323
$generator->startHashElement('Location');

phpstan-baseline.neon

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,6 @@ parameters:
210210
count: 1
211211
path: code_samples/api/rest_api/src/Rest/ValueObjectVisitor/Greeting.php
212212

213-
-
214-
message: '#^Method App\\Rest\\ValueObjectVisitor\\RestLocation\:\:visit\(\) has no return type specified\.$#'
215-
identifier: missingType.return
216-
count: 1
217-
path: code_samples/api/rest_api/src/Rest/ValueObjectVisitor/RestLocation.php
218-
219213
-
220214
message: '#^Parameter \#1 \.\.\.\$arrays of function array_merge expects array, iterable\<Ibexa\\Contracts\\Core\\Repository\\Values\\Content\\URLAlias\> given\.$#'
221215
identifier: argument.type

0 commit comments

Comments
 (0)