IBX-4470: Rebranded Flysystem filesystem service ID (#616)

alongosz · web-flow · commit d9b72df6b2c6 · 2025-07-15T05:30:01.000+02:00
* Rebranded Flysystem filesystem service ID
* [Tests] Aligned BaseFlysystemTestCase with rebranded service ID
* [PHPStan] Removed resolved issue from the baseline
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -24798,12 +24798,6 @@ parameters:
 			count: 1
 			path: tests/bundle/IO/DependencyInjection/ConfigurationFactory/BaseFlysystemTestCase.php
 
-		-
-			message: '#^Property Ibexa\\Tests\\Bundle\\IO\\DependencyInjection\\ConfigurationFactory\\BaseFlysystemTestCase\:\:\$filesystemServiceId has no type specified\.$#'
-			identifier: missingType.property
-			count: 1
-			path: tests/bundle/IO/DependencyInjection/ConfigurationFactory/BaseFlysystemTestCase.php
-
 		-
 			message: '#^Property Ibexa\\Tests\\Bundle\\IO\\DependencyInjection\\ConfigurationFactory\\BaseFlysystemTestCase\:\:\$flysystemAdapterServiceId has no type specified\.$#'
 			identifier: missingType.property
diff --git a/src/bundle/IO/DependencyInjection/ConfigurationFactory/Flysystem.php b/src/bundle/IO/DependencyInjection/ConfigurationFactory/Flysystem.php
@@ -65,7 +65,7 @@ private function createFilesystem(ContainerBuilder $container, $name, $adapter):
             throw new InvalidConfigurationException("Unknown flysystem adapter $adapter");
         }
 
-        $filesystemId = sprintf('ezpublish.core.io.flysystem.%s_filesystem', $name);
+        $filesystemId = sprintf('ibexa.core.io.flysystem.%s_filesystem', $name);
         $filesystemServiceDefinition = new ChildDefinition('ibexa.core.io.flysystem.base_filesystem');
         $definition = $container->setDefinition(
             $filesystemId,
diff --git a/tests/bundle/IO/DependencyInjection/ConfigurationFactory/BaseFlysystemTestCase.php b/tests/bundle/IO/DependencyInjection/ConfigurationFactory/BaseFlysystemTestCase.php
@@ -15,7 +15,7 @@ abstract class BaseFlysystemTestCase extends ConfigurationFactoryTestCase
 {
     private $flysystemAdapterServiceId = 'oneup_flysystem.test_adapter';
 
-    private $filesystemServiceId = 'ezpublish.core.io.flysystem.my_test_handler_filesystem';
+    private string $filesystemServiceId = 'ibexa.core.io.flysystem.my_test_handler_filesystem';
 
     public function provideHandlerConfiguration()
     {

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ private function createFilesystem(ContainerBuilder $container, $name, $adapter):`
`65`	`65`	`throw new InvalidConfigurationException("Unknown flysystem adapter $adapter");`
`66`	`66`	`}`
`67`	`67`
`68`		`- $filesystemId = sprintf('ezpublish.core.io.flysystem.%s_filesystem', $name);`
	`68`	`+ $filesystemId = sprintf('ibexa.core.io.flysystem.%s_filesystem', $name);`
`69`	`69`	`$filesystemServiceDefinition = new ChildDefinition('ibexa.core.io.flysystem.base_filesystem');`
`70`	`70`	`$definition = $container->setDefinition(`
`71`	`71`	`$filesystemId,`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ abstract class BaseFlysystemTestCase extends ConfigurationFactoryTestCase`
`15`	`15`	`{`
`16`	`16`	`private $flysystemAdapterServiceId = 'oneup_flysystem.test_adapter';`
`17`	`17`
`18`		`- private $filesystemServiceId = 'ezpublish.core.io.flysystem.my_test_handler_filesystem';`
	`18`	`+ private string $filesystemServiceId = 'ibexa.core.io.flysystem.my_test_handler_filesystem';`
`19`	`19`
`20`	`20`	`public function provideHandlerConfiguration()`
`21`	`21`	`{`