IBX-9060: Refactored after review

Author: tbialcz

src/lib/Persistence/Cache/NotificationHandler.php

@@ -54,7 +54,7 @@ public function bulkUpdateUserNotifications(
             ->bulkUpdateUserNotifications($ownerId, $updateStruct, $pendingOnly, $notificationIds);
 
         $cacheKeys = array_map(
-            fn (int $id) => $this->cacheIdentifierGenerator->generateKey(self::NOTIFICATION_IDENTIFIER, [$id], true),
+            fn (int $id): string => $this->cacheIdentifierGenerator->generateKey(self::NOTIFICATION_IDENTIFIER, [$id], true),
             $updatedNotificationIds
         );
 

src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php

@@ -92,7 +92,7 @@ public function bulkUpdateUserNotifications(
         bool $pendingOnly = false,
         array $notificationIds = []
     ): array {
-        if (!is_int($notification->ownerId) || $notification->ownerId <= 0) {
+        if (!is_int($notification->ownerId)) {
             throw new InvalidArgumentException('ownerId', 'Cannot bulk update notifications without valid ownerId');
         }
 
@@ -101,7 +101,7 @@ public function bulkUpdateUserNotifications(
             ->select(self::COLUMN_ID)
             ->from(self::TABLE_NOTIFICATION)
             ->andWhere($queryBuilder->expr()->eq(self::COLUMN_OWNER_ID, ':ownerId'))
-            ->setParameter(':ownerId', $notification->ownerId, PDO::PARAM_INT);
+            ->setParameter(':ownerId', $notification->ownerId, ParameterType::INTEGER);
 
         if ($pendingOnly) {
             $queryBuilder->andWhere($queryBuilder->expr()->eq(self::COLUMN_IS_PENDING, ':isPendingFlag'))