Skip to content

[WiP] V4-> V5 Upgrade testing PR #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

[WiP] V4-> V5 Upgrade testing PR #108

wants to merge 53 commits into from

Conversation

tomaszszopinski
Copy link
Contributor

@tomaszszopinski tomaszszopinski commented Jun 23, 2025

🎫 Issue IBX-XXXXX

Related PRs:

Description:

@@ -2,7 +2,7 @@
set -e

PROJECT_EDITION=$1
PROJECT_VERSION=$2
PROJECT_VERSION=5.0.x-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PROJECT_VERSION=5.0.x-dev
PROJECT_VERSION=4.6.x-dev

We need to start with 4.6 first, only then manually update


# Upgrade Ibexa and Symfony packages (main app)
docker compose --env-file=.env exec -T --user www-data app sh -c "composer require --no-update \
ibexa/commerce:5.0.x-dev \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ibexa/commerce:5.0.x-dev \
ibexa/commerce:5.0.x-dev \
ibexa/behat:5.0.x-dev \
ibexa/docker:5.0.x-dev \

We will probably need to update these as well

Comment on lines 220 to 221
ibexa/admin-ui-assets:v5.0.0-alpha5 \
ibexa/headless-assets:v5.0.0-alpha4 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ibexa/admin-ui-assets:v5.0.0-alpha5 \
ibexa/headless-assets:v5.0.0-alpha4 \
ibexa/admin-ui-assets:v5.0.0-beta2 \
ibexa/headless-assets:v5.0.0-beta1 \

Copy link

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few double quotes to escape


# Generate new GraphQL schema if used (while admin-ui doesn't use it anymore)
# docker compose exec -T --user www-data app sh -c 'php bin/console cache:pool:clear ${CACHE_POOL:-cache.tagaware.filesystem}'
docker compose --env-file=.env exec -T --user www-data app sh -c "composer require ibexa/graphql --no-interaction"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require can be removed as ibexa/graphql is still included in 5.0. (I misinterpreted the fact that it's not used anymore by admin-ui.)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants