Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function show_dplyr() #8

Closed
ianmcook opened this issue Jan 4, 2020 · 4 comments
Closed

Add function show_dplyr() #8

ianmcook opened this issue Jan 4, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@ianmcook
Copy link
Owner

ianmcook commented Jan 4, 2020

Add a function show_dplyr() that prints the resulting dplyr code instead of running it.
ianmcook pushed a commit that referenced this issue Jan 4, 2020
Modify query() to prepare for addition of show_dplyr() (#8)
6a3156c
ianmcook pushed a commit that referenced this issue Jan 5, 2020
Document show_dplyr() function (#8)
4a0fa36
@ianmcook
Copy link
Owner Author

ianmcook commented Jan 5, 2020 •
edited
Loading

The current implementation of show_dplyr() has the following known issue:

  • Inside calls to functions with more than 5 arguments passed to them, all arguments beyond the 5th are truncated in the printed dplyr code. This is caused by truncation logic in rlang:::list_deparse().

@ianmcook ianmcook added the enhancement New feature or request label Jan 17, 2020
@ianmcook
Copy link
Owner Author

I documented the argument truncation behavior and added a test for it in c1aee8c.

@ianmcook
Copy link
Owner Author

I opened an rlang PR to control the truncation behavior r-lib/rlang#897

@ianmcook
Copy link
Owner Author

I made changes to prepare for r-lib/rlang#897 in 77c12a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianmcook