fix: make qwik-testing-library agnostic from vitest runner #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `mock$` is currently relying on `vi.fn()` from `vitest` to create mock functions, we cannot make it part of `qwik-testing-library` to provide mocking utilities. We need to extract it as a separate lib. BREAKING CHANGE: extract qwik-mock from qwik-testing-library as a separate lib
ianlet
force-pushed
the
fix-vitest-dependency
branch
from
6dda4a6 to
c837f33
Compare
|
🎉 This PR is included in version @noma.to/qwik-mock-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @noma.to/qwik-testing-library-v1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @thejackshelton for review |
|
I've put up a pull request to add @thejackshelton! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the experimental
mock$function is currently relying onvi.fn()fromvitestto create mock functions, we cannot make it part ofqwik-testing-libraryto provide mocking utilities. We need to extract it as a separate lib.BREAKING CHANGE: extract qwik-mock from qwik-testing-library as a separate lib