Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rolling 1d99999999999999999999999999999999 always returns 1 #469

Open
ianfhunter opened this issue Mar 23, 2024 · 2 comments
Open

rolling 1d99999999999999999999999999999999 always returns 1 #469

ianfhunter opened this issue Mar 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working the way it should

Comments

@ianfhunter
Copy link
Owner

Describe the bug

rolling 1d99999999999999999999999999999999 always returns 1

To Reproduce

./build/dice 1d99999999999999999999999999999999

Expected behavior

Either:

  • An error
    or
  • A value between 1 and rolling 99999999999999999999999999999999

Environment (please complete the following information):

Any

Additional context

@ianfhunter ianfhunter added bug Something isn't working the way it should good first issue Good for newcomers labels Mar 23, 2024
@ianfhunter ianfhunter self-assigned this Mar 23, 2024
@ianfhunter
Copy link
Owner Author

If we go over a max size, we could do what some games do for rolling d100s with only d10s
that is CONCAT(d10, d10) == d100

We will probably bump into issues with YACC. However, the theory means we could do arbitrarily long dice.

I am sure that many people are not using GNOLL because we cannot support

1d99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999

@ianfhunter
Copy link
Owner Author

Size increased to Long Long but we can go further

@ianfhunter ianfhunter removed the good first issue Good for newcomers label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way it should
Projects
None yet
Development

No branches or pull requests

1 participant