Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LogicalKVv2 type #6

Open
ianferguson opened this issue Feb 2, 2021 · 0 comments
Open

Create LogicalKVv2 type #6

ianferguson opened this issue Feb 2, 2021 · 0 comments

Comments

@ianferguson
Copy link
Owner

Setting the entire Vault client to "v1" or "v2" to handle the differences in the KVv1 and KVv2 Vault APIs works well enough for use cases where users only use a KV mount and the version of the KV mounts used in the target Vault cluster are homogeneous.

I think its worth deprecating that as a "driver" level feature and replacing it with:

  • a LogicalKVv2 type returned from Vault
  • the ability to configure Logical to optionally use Vault's (not fully documented) /sys/internal/ui/mounts/* preflight check endpoints to auto-detect the logical version to use, for use cases where the user is expected to have permission to access those and the extra round trip call to vault is acceptable in exchange for transparently negotiating KV v1 vs v2 mounts

This should give a better user experience and avoid frequent confusion with non KV mounts being used alongside KVv2 mounts in the same Vault instance such as:

Related To:

TBD:

  • Should the mount map constructor also be deprecated and phased in in a later major version? I think so -- we don't pass a map of database backends or PKI secret backends, they are just interacted with directly using the API types returned by the Vault type -- KVv1 vs KVv2 mounts can be handled via API types too, rather than a special case map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant