Update dependency declarations: adjust api vs implementation, remove …

…unused ones

This change brings dependency analysis plugin:

  ./gradlew buildHealth --no-parallel --no-daemon

Most of the times the suggestions are good, however, there are still issues,
so don't blindly follow the recommendations.

See https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin

babel/build.gradle.kts

@@ -15,17 +15,16 @@
  * limitations under the License.
  */
 plugins {
-    kotlin("jvm")
     id("com.github.vlsi.ide")
     calcite.fmpp
     calcite.javacc
 }
 
 dependencies {
     api(project(":core"))
+    api("org.apache.calcite.avatica:avatica-core")
 
     implementation("com.google.guava:guava")
-    implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.slf4j:slf4j-api")
 
     testImplementation("net.hydromatic:quidem")

build.gradle.kts

@@ -54,6 +54,7 @@ plugins {
     id("com.github.vlsi.gradle-extensions")
     id("com.github.vlsi.license-gather") apply false
     id("com.github.vlsi.stage-vote-release")
+    id("com.autonomousapps.dependency-analysis")
 }
 
 repositories {
@@ -233,6 +234,23 @@ val buildSqllineClasspath by tasks.registering(Jar::class) {
     }
 }
 
+dependencyAnalysis {
+    // See https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin
+    // Most of the time the recommendations are good, however, there are cases the suggestsions
+    // are off, so we don't include the dependency analysis to CI workflow yet
+    // ./gradlew buildHealth --no-parallel --no-daemon
+    issues {
+        all { // all projects
+            onAny {
+                severity("fail")
+            }
+            onRedundantPlugins {
+                severity("ignore")
+            }
+        }
+    }
+}
+
 val javaccGeneratedPatterns = arrayOf(
     "org/apache/calcite/jdbc/CalciteDriverVersion.java",
     "**/parser/**/*ParserImpl.*",

cassandra/build.gradle.kts

@@ -18,10 +18,11 @@ dependencies {
     api(project(":core"))
     api(project(":linq4j"))
 
-    implementation("com.datastax.cassandra:cassandra-driver-core")
-    implementation("com.google.guava:guava")
+    api("com.datastax.cassandra:cassandra-driver-core")
+    api("com.google.guava:guava")
+    api("org.slf4j:slf4j-api")
+
     implementation("org.apache.calcite.avatica:avatica-core")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("org.apache.cassandra:cassandra-all") {

core/build.gradle.kts

@@ -39,34 +39,35 @@ val testMysql by configurations.creating(integrationTestConfig)
 dependencies {
     api(project(":linq4j"))
 
+    api("com.esri.geometry:esri-geometry-api")
     api("com.fasterxml.jackson.core:jackson-annotations")
+    api("com.google.errorprone:error_prone_annotations")
+    api("com.google.guava:guava")
     api("org.apache.calcite.avatica:avatica-core")
     api("org.apiguardian:apiguardian-api")
+    api("org.checkerframework:checker-qual")
+    api("org.slf4j:slf4j-api")
 
-    implementation("com.esri.geometry:esri-geometry-api")
     implementation("com.fasterxml.jackson.core:jackson-core")
     implementation("com.fasterxml.jackson.core:jackson-databind")
     implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml")
-    implementation("com.google.errorprone:error_prone_annotations")
-    implementation("com.google.guava:guava")
     implementation("com.google.uzaygezen:uzaygezen-core")
     implementation("com.jayway.jsonpath:json-path")
     implementation("com.yahoo.datasketches:sketches-core")
     implementation("commons-codec:commons-codec")
     implementation("net.hydromatic:aggdesigner-algorithm")
     implementation("org.apache.commons:commons-dbcp2")
     implementation("org.apache.commons:commons-lang3")
-    implementation("org.checkerframework:checker-qual")
     implementation("commons-io:commons-io")
     implementation("org.codehaus.janino:commons-compiler")
     implementation("org.codehaus.janino:janino")
-    implementation("org.slf4j:slf4j-api")
 
     testH2("com.h2database:h2")
     testMysql("mysql:mysql-connector-java")
     testOracle("com.oracle.ojdbc:ojdbc8")
     testPostgresql("org.postgresql:postgresql")
 
+    testImplementation("commons-lang:commons-lang")
     testImplementation("net.hydromatic:foodmart-data-hsqldb")
     testImplementation("net.hydromatic:foodmart-queries")
     testImplementation("net.hydromatic:quidem")

druid/build.gradle.kts

@@ -17,15 +17,15 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.fasterxml.jackson.core:jackson-core")
+    api("joda-time:joda-time")
+    api("org.apache.calcite.avatica:avatica-core")
+    api("org.checkerframework:checker-qual")
+    api("org.slf4j:slf4j-api")
 
-    implementation("com.fasterxml.jackson.core:jackson-core")
     implementation("com.fasterxml.jackson.core:jackson-databind")
     implementation("com.google.guava:guava")
-    implementation("joda-time:joda-time")
-    implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.commons:commons-lang3")
-    implementation("org.checkerframework:checker-qual")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("org.mockito:mockito-core")

elasticsearch/build.gradle.kts

@@ -25,16 +25,17 @@ dependencies {
     api(project(":linq4j"))
 
     api("com.fasterxml.jackson.core:jackson-annotations")
+    api("com.fasterxml.jackson.core:jackson-core")
+    api("com.fasterxml.jackson.core:jackson-databind")
+    api("org.elasticsearch.client:elasticsearch-rest-client")
+    api("org.slf4j:slf4j-api")
 
-    implementation("com.fasterxml.jackson.core:jackson-core")
-    implementation("com.fasterxml.jackson.core:jackson-databind")
     implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
+    implementation("org.apache.httpcomponents:httpasyncclient")
     implementation("org.apache.httpcomponents:httpclient")
     implementation("org.apache.httpcomponents:httpcore")
     implementation("org.checkerframework:checker-qual")
-    implementation("org.elasticsearch.client:elasticsearch-rest-client")
-    implementation("org.slf4j:slf4j-api")
 
     // https://github.com/elastic/elasticsearch/issues/49218
     if (project.props.bool("elasticStrictAsm", default = true)) {

example/csv/build.gradle.kts

@@ -23,14 +23,12 @@ dependencies {
     api(project(":core"))
     api(project(":file"))
     api(project(":linq4j"))
+    api("org.checkerframework:checker-qual")
 
     implementation("com.fasterxml.jackson.core:jackson-core")
     implementation("com.fasterxml.jackson.core:jackson-databind")
     implementation("com.google.guava:guava")
-    implementation("commons-io:commons-io")
-    implementation("net.sf.opencsv:opencsv")
     implementation("org.apache.calcite.avatica:avatica-core")
-    implementation("org.apache.commons:commons-lang3")
 
     testImplementation("sqlline:sqlline")
     testImplementation(project(":core", "testClasses"))

example/function/build.gradle.kts

@@ -17,6 +17,7 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.checkerframework:checker-qual")
 
     implementation("com.google.guava:guava") {
         because("""ForbiddenApis' signatures.txt contains com.google.common.base.Precondition

file/build.gradle.kts

@@ -17,6 +17,7 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.checkerframework:checker-qual")
 
     implementation("com.google.guava:guava")
     implementation("com.joestelmach:natty")
@@ -25,6 +26,8 @@ dependencies {
     implementation("commons-io:commons-io")
     implementation("org.apache.commons:commons-lang3")
     implementation("org.jsoup:jsoup")
+    implementation("com.fasterxml.jackson.core:jackson-core")
+    implementation("com.fasterxml.jackson.core:jackson-databind")
 
     testImplementation(project(":core", "testClasses"))
 }

geode/build.gradle.kts

@@ -17,12 +17,13 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.apache.geode:geode-core")
+    api("org.checkerframework:checker-qual")
+    api("org.slf4j:slf4j-api")
 
     implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.commons:commons-lang3")
-    implementation("org.apache.geode:geode-core")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("com.fasterxml.jackson.core:jackson-databind")

gradle.properties

@@ -43,6 +43,7 @@ calcite.avatica.version=1.17.0
 # publishGradleMetadata=true
 
 # Plugins
+com.autonomousapps.dependency-analysis.version=0.71.0
 org.checkerframework.version=0.5.16
 com.github.autostyle.version=3.0
 com.github.burrunan.s3-build-cache.version=1.1

innodb/build.gradle.kts

@@ -17,9 +17,10 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.alibaba.database:innodb-java-reader")
+    api("com.google.guava:guava")
 
-    implementation("com.alibaba.database:innodb-java-reader")
-    implementation("com.google.guava:guava")
+    implementation("commons-collections:commons-collections")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.commons:commons-lang3")
     implementation("org.slf4j:slf4j-api")

kafka/build.gradle.kts

@@ -17,9 +17,10 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.apache.kafka:kafka-clients")
+    api("org.checkerframework:checker-qual")
 
     implementation("com.google.guava:guava")
-    implementation("org.apache.kafka:kafka-clients")
 
     testImplementation(project(":core", "testClasses"))
 }

linq4j/build.gradle.kts

@@ -16,8 +16,8 @@
  */
 dependencies {
     api("org.apiguardian:apiguardian-api")
+    api("org.checkerframework:checker-qual")
 
     implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
-    implementation("org.checkerframework:checker-qual")
 }

mongodb/build.gradle.kts

@@ -17,11 +17,11 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.google.guava:guava")
+    api("org.slf4j:slf4j-api")
 
-    implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.mongodb:mongo-java-driver")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("de.bwaldvogel:mongo-java-server-core")

pig/build.gradle.kts

@@ -17,11 +17,10 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.google.guava:guava")
 
-    implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.pig:pig::h2")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("org.apache.hadoop:hadoop-client")

piglet/build.gradle.kts

@@ -22,11 +22,11 @@ plugins {
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.google.guava:guava")
+    api("org.apache.pig:pig::h2")
 
-    implementation("com.google.guava:guava")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.hadoop:hadoop-common")
-    implementation("org.apache.pig:pig::h2")
     implementation("org.checkerframework:checker-qual")
     implementation("org.slf4j:slf4j-api")
 

plus/build.gradle.kts

@@ -17,16 +17,16 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("net.hydromatic:quidem")
+    api("org.apache.calcite.avatica:avatica-core")
+    api("org.checkerframework:checker-qual")
 
     implementation("com.google.guava:guava")
     implementation("com.teradata.tpcds:tpcds")
     implementation("io.prestosql.tpch:tpch")
     implementation("net.hydromatic:chinook-data-hsqldb")
-    implementation("net.hydromatic:quidem")
     implementation("net.hydromatic:tpcds")
-    implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.calcite.avatica:avatica-server")
-    implementation("org.eclipse.jetty:jetty-server")
     implementation("org.hsqldb:hsqldb")
 
     testImplementation(project(":core", "testClasses"))

redis/build.gradle.kts

@@ -17,17 +17,15 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("redis.clients:jedis")
 
     implementation("com.fasterxml.jackson.core:jackson-core")
     implementation("com.fasterxml.jackson.core:jackson-databind")
-    implementation("com.github.kstyrc:embedded-redis")
     implementation("com.google.guava:guava")
-    implementation("joda-time:joda-time")
     implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.apache.commons:commons-lang3")
     implementation("org.apache.commons:commons-pool2")
     implementation("org.slf4j:slf4j-api")
-    implementation("redis.clients:jedis")
 
     testImplementation(project(":core", "testClasses"))
     testImplementation("com.github.kstyrc:embedded-redis")

server/build.gradle.kts

@@ -23,9 +23,9 @@ plugins {
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.apache.calcite.avatica:avatica-core")
 
     implementation("com.google.guava:guava")
-    implementation("org.apache.calcite.avatica:avatica-core")
     implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))

settings.gradle.kts

@@ -19,6 +19,7 @@ pluginManagement {
         fun String.v() = extra["$this.version"].toString()
         fun PluginDependenciesSpec.idv(id: String, key: String = id) = id(id) version key.v()
 
+        idv("com.autonomousapps.dependency-analysis")
         idv("org.checkerframework")
         idv("com.github.autostyle")
         idv("com.github.burrunan.s3-build-cache")

spark/build.gradle.kts

@@ -17,9 +17,9 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("org.apache.spark:spark-core_2.10")
 
     implementation("com.google.guava:guava")
-    implementation("org.apache.spark:spark-core_2.10")
     implementation("org.eclipse.jetty:jetty-server")
     implementation("org.eclipse.jetty:jetty-util")
     implementation("org.scala-lang:scala-library")

splunk/build.gradle.kts

@@ -17,11 +17,11 @@
 dependencies {
     api(project(":core"))
     api(project(":linq4j"))
+    api("com.google.guava:guava")
+    api("org.apache.calcite.avatica:avatica-core")
+    api("org.slf4j:slf4j-api")
 
-    implementation("com.google.guava:guava")
     implementation("net.sf.opencsv:opencsv")
-    implementation("org.apache.calcite.avatica:avatica-core")
-    implementation("org.slf4j:slf4j-api")
 
     testImplementation(project(":core", "testClasses"))
     testRuntimeOnly("org.slf4j:slf4j-log4j12")