Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Duration Plugin #564

Closed
iamkun opened this issue Apr 9, 2019 · 24 comments · Fixed by #858
Closed

Feature request: Add Duration Plugin #564

iamkun opened this issue Apr 9, 2019 · 24 comments · Fixed by #858
Labels
discussion Further discussion released

Comments

@iamkun
Copy link
Owner

iamkun commented Apr 9, 2019

Update: DONE 🎉🎉🎉🎉🎉🎉

Duration
https://day.js.org/docs/en/durations/durations

v1.8.24


Official duration plugin #858


Goal: to keep the same with moment.duration

  1. Parse ISO duration format Considering add duration? #122
  2. Duration object to ISO string toISOString() Converting to ISO 8601 standard duration format #519
  3. Using Duration with Diff .duration(x.diff(y)) how can i compare date like moment.duration #414

ref: https://en.wikipedia.org/wiki/ISO_8601#Durations


IssueHunt Summary

iamkun iamkun has been rewarded.

Backers (Total: $116.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@iamkun iamkun added the discussion Further discussion label Apr 9, 2019
@iamkun iamkun changed the title TODO: Add Duration Plugin Feature request: Add Duration Plugin Apr 11, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $100.00 to this issue.


@iamkun
Copy link
Owner Author

iamkun commented Apr 12, 2019

WIP

@IssueHuntBot
Copy link

@xxyuk has funded $2.00 to this issue.


@IssueHuntBot
Copy link

@zazzaz has funded $2.00 to this issue.


@IssueHuntBot
Copy link

@waseemahmad31 has funded $2.00 to this issue.


@u01jmg3
Copy link

u01jmg3 commented May 28, 2019

Could this include functionality similar to moment-duration-format?

@iamkun
Copy link
Owner Author

iamkun commented May 30, 2019

will include moment.duration in the first step

@lockee14
Copy link

hi, may I work on this one? I did the plugin on my fork and it works
see:
durationISO8601

it return an object with this format:
const duration = { ISO: '', s: 0, m: 0, H: 0, D: 0, M: 0, y: 0 }

@Wyzix33
Copy link

Wyzix33 commented Aug 2, 2019

Any news on this?

@kfreiman
Copy link

kfreiman commented Aug 6, 2019

alternative: humanize-duration package
it may be convenient to use that package as dependency in the Duration plugin

@Flcwl
Copy link

Flcwl commented Oct 26, 2019

how I can use it?

@romanlex
Copy link

Any news on this? (

@iamgbayer
Copy link

Any news on this?

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jan 30, 2020

@muuvmuuv has funded $10.00 to this issue.


@Indigo744
Copy link

Hello, any news regarding the work on the duration plugin?

@lockee14 provided a PR (#621), is something preventing from merging it?

Thanks.

@milobluebell
Copy link

have the same 请尽快合并pr吧 @iamkun

@mackelito
Copy link

Any updates here? Would really like to have it :)

@mackelito
Copy link

Just to be clear.. I'm looking for something similar to https://momentjs.com/docs/#/durations/ :)

@mackelito
Copy link

@iamkun any feed back would be greatly appreciated.. just to let us know an eta or even if this will ever happen.. :/

@issuehunt-oss

This comment has been minimized.

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Apr 8, 2020
@iamkun iamkun removed the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Apr 8, 2020
@sybers
Copy link

sybers commented Apr 8, 2020

Hooray !

@muuvmuuv
Copy link

muuvmuuv commented Apr 9, 2020

Documentation missing and not yet released right?

@iamkun
Copy link
Owner Author

iamkun commented Apr 9, 2020

@muuvmuuv will release in the next release this week.

@iamkun
Copy link
Owner Author

iamkun commented Apr 10, 2020

🎉 This issue has been resolved in version 1.8.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Further discussion released
Projects
None yet
Development

Successfully merging a pull request may close this issue.