Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YYYY-MM-DD Format Not Working #555

Closed
GoPro16 opened this issue Apr 2, 2019 · 7 comments
Closed

YYYY-MM-DD Format Not Working #555

GoPro16 opened this issue Apr 2, 2019 · 7 comments
Labels
☢️Bug Something isn't working 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released

Comments

@GoPro16
Copy link

GoPro16 commented Apr 2, 2019 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

Describe the bug
When passing in a parse format of YYYY-MM-DD with an invalid date string of 10/12/2014, should result in and invalid date but instead resolves to 08-14-2015

Expected behavior
Should result in date.isValid() === false

Information

  • Day.js Version [e.g. v1.8.11]
  • OS: [e.g. MacOS]
  • Browser [e.g. chrome 73]

CodeSandbox Link

IssueHunt Summary

iamkun iamkun has been rewarded.

Backers (Total: $50.00)

Submitted pull Requests

Tips

IssueHunt has been backed by the following sponsors. Become a sponsor
@GoPro16 GoPro16 mentioned this issue Apr 2, 2019
Merged
@ghost
Copy link

ghost commented Apr 3, 2019 •
edited by ghost
Loading

With customParseFormat plugin
dayjs('2014-12-01', 'YYYY-MM-DD').toISOString() returns 2014-12-01T00:00:00.000Z

Looks good.

@GoPro16
Copy link
Author

GoPro16 commented Apr 4, 2019

@xxyuk Right sorry, I updated my issue comments. If you check the codesandbox it should be throwing an error when trying to parse the invalid date format but instead parses to a random date.

@iamkun iamkun added the ☢️Bug Something isn't working label Apr 8, 2019
@iamkun
Copy link
Owner

iamkun commented Apr 8, 2019

will fix soon

@IssueHuntBot
Copy link

@IssueHunt has funded $50.00 to this issue.

@waseemahmad31 waseemahmad31 mentioned this issue Apr 14, 2019
Merged
@iamkun iamkun closed this as completed in 1f5a9db Apr 15, 2019
iamkun pushed a commit that referenced this issue Apr 26, 2019
@semantic-release-bot
chore(release): 1.8.13 [skip ci]
68a04e1 
## [1.8.13](v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](#560)) ([96b917e](96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](#569)) ([9007cc5](9007cc5)), closes [#559](#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](#580)) ([576e93e](576e93e)), closes [#578](#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](800f6c9))
* Fix `.diff` type definition error ([#565](#565)) ([c4921ae](c4921ae)), closes [#561](#561)
* Fix CustomParseFormat plugin bug ([#568](#568)) ([1f5a9db](1f5a9db)), closes [#555](#555)
* Fix relativeTime plugin Math.round bug ([40bea40](40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](#556)) ([9279718](9279718)), closes [#554](#554)
* Update Indonesian locale([#574](#574)) ([0aa7143](0aa7143))
* Update locale month to support both array and function ([#581](#581)) ([b6599d3](b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](#557)) ([d409304](d409304))
@iamkun
Copy link
Owner

iamkun commented Apr 26, 2019

🎉 This issue has been resolved in version 1.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@issuehunt-oss

This comment has been minimized.

Sign in to view
@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Sep 16, 2019
@adil-chbada
Copy link

https://day.js.org/docs/en/plugin/custom-parse-format#docsNav

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
b38f060 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.13 [skip ci]
ec17709 
## [1.8.13](iamkun/dayjs@v1.8.12...v1.8.13) (2019-04-26)

### Bug Fixes

* Add missing relativeTime and formats for some locales ([#560](iamkun/dayjs#560)) ([96b917e](iamkun/dayjs@96b917e))
* Add weekday (locale aware day of the week) plugin ([#569](iamkun/dayjs#569)) ([9007cc5](iamkun/dayjs@9007cc5)), closes [#559](iamkun/dayjs#559)
* Allow customizing "am" / "pm" strings with locale meridiem function ([#580](iamkun/dayjs#580)) ([576e93e](iamkun/dayjs@576e93e)), closes [#578](iamkun/dayjs#578)
* Fix `.add` day/week decimal rouding bug ([800f6c9](iamkun/dayjs@800f6c9))
* Fix `.diff` type definition error ([#565](iamkun/dayjs#565)) ([c4921ae](iamkun/dayjs@c4921ae)), closes [#561](iamkun/dayjs#561)
* Fix CustomParseFormat plugin bug ([#568](iamkun/dayjs#568)) ([1f5a9db](iamkun/dayjs@1f5a9db)), closes [#555](iamkun/dayjs#555)
* Fix relativeTime plugin Math.round bug ([40bea40](iamkun/dayjs@40bea40))
* skip square brackets in  buddhistEra, advancedFormat plugins ([#556](iamkun/dayjs#556)) ([9279718](iamkun/dayjs@9279718)), closes [#554](iamkun/dayjs#554)
* Update Indonesian locale([#574](iamkun/dayjs#574)) ([0aa7143](iamkun/dayjs@0aa7143))
* Update locale month to support both array and function ([#581](iamkun/dayjs#581)) ([b6599d3](iamkun/dayjs@b6599d3))
* Update LocalizedFormat plugin lowercase formats logic ([#557](iamkun/dayjs#557)) ([d409304](iamkun/dayjs@d409304))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adil-chbada @GoPro16 @iamkun @IssueHuntBot