Add crash address parsing for GDB. (google#1770)

Author: mspectorgoogle

src/python/crash_analysis/stack_parsing/stack_analyzer.py

@@ -132,6 +132,8 @@
     r'cannot open shared object file')
 LINUX_GDB_CRASH_TYPE_REGEX = re.compile(r'Program received signal ([a-zA-Z]+),')
 LINUX_GDB_CRASH_ADDRESS_REGEX = re.compile(r'rip[ ]+([xX0-9a-fA-F]+)')
+LINUX_GDB_CRASH_ADDRESS_NO_REGISTERS_REGEX = re.compile(
+    r'^(0[xX][0-9a-fA-F]+)\s+in\s+')
 LSAN_DIRECT_LEAK_REGEX = re.compile(r'Direct leak of ')
 LSAN_INDIRECT_LEAK_REGEX = re.compile(r'Indirect leak of ')
 MAC_GDB_CRASH_ADDRESS_REGEX = re.compile(
@@ -334,6 +336,7 @@
     # Function names (startswith).
     r'^(|\_\_)memcmp',
     r'^(|\_\_)memcpy',
+    r'^(|\_\_)aeabi\_',
     r'^(|\_\_)memmove',
     r'^(|\_\_)memset',
     r'^(|\_\_)strcmp',
@@ -1235,6 +1238,13 @@ def get_crash_data(crash_data, symbolize_flag=True):
     update_state_on_match(
         LINUX_GDB_CRASH_ADDRESS_REGEX, line, state, address_from_group=1)
 
+    # Platform specific: Linux gdb crash address format no registers
+    update_state_on_match(
+        LINUX_GDB_CRASH_ADDRESS_NO_REGISTERS_REGEX,
+        line,
+        state,
+        address_from_group=1)
+
     # Platform specific: Mac gdb style crash address format.
     update_state_on_match(
         MAC_GDB_CRASH_ADDRESS_REGEX, line, state, address_from_group=1)

src/python/tests/core/crash_analysis/stack_parsing/stack_analyzer_data/gdb_sigtrap.txt

@@ -0,0 +1,11 @@
+0x0000000000000ac8 in __aeabi_memcpy ()
+
+Program received signal SIGTRAP, Trace/breakpoint trap.
+0x0000000000000ac8 in __aeabi_memcpy ()
+#0  0x0000000000000ac8 in __aeabi_memcpy ()
+#1  0x00000000000007d8 in memcpy ()
+#2  0x000000000000cdc0 in xymodem_trnasfer (target_addr=0x2022000, max_sz=<optimized out>, prot_type=1) at usbdev/protocol_xymodem.c:362
+#3  0x0000000000002060 in LoadImageFromUsb30 (uTargetAddr=<optimized out>, uSizeLimit=<optimized out>, req_type=3239010) at usbdev/usbdev_api.c:267
+#4  0x0000000000001fec in LoadBL1FromUsb30 () at usbdev/usbdev_api.c:225
+#5  0x0000000000004514 in Main () at boot/main.c:94
+#6  0x0000000000000044 in GPIO_SetPudBits (SFR_Address=<optimized out>, base=<optimized out>, mask=<optimized out>, value=<optimized out>) at gpio/gpio.c:38

src/python/tests/core/crash_analysis/stack_parsing/stack_analyzer_data/gdb_sigtrap_and_libfuzzer.txt

@@ -0,0 +1,24 @@
+0x0000000000000ac8 in __aeabi_memcpy ()
+
+Program received signal SIGTRAP, Trace/breakpoint trap.
+0x0000000000000ac8 in __aeabi_memcpy ()
+#0  0x0000000000000ac8 in __aeabi_memcpy ()
+#1  0x00000000000007d8 in memcpy ()
+#2  0x000000000000cdc0 in xymodem_trnasfer (target_addr=0x2022000, max_sz=<optimized out>, prot_type=1) at usbdev/protocol_xymodem.c:362
+#3  0x0000000000002060 in LoadImageFromUsb30 (uTargetAddr=<optimized out>, uSizeLimit=<optimized out>, req_type=3239010) at usbdev/usbdev_api.c:267
+#4  0x0000000000001fec in LoadBL1FromUsb30 () at usbdev/usbdev_api.c:225
+#5  0x0000000000004514 in Main () at boot/main.c:94
+#6  0x0000000000000044 in GPIO_SetPudBits (SFR_Address=<optimized out>, base=<optimized out>, mask=<optimized out>, value=<optimized out>) at gpio/gpio.c:38
+==111736== ERROR: libFuzzer: deadly signal
+    #0 0x4b3520 in __sanitizer_print_stack_trace (/usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/libfuzzer/fuzzer+0x4b3520)
+    #1 0x45e158 in fuzzer::PrintStackTrace() (/usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/libfuzzer/fuzzer+0x45e158)
+    #2 0x4438c3 in fuzzer::Fuzzer::CrashCallback() (/usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/libfuzzer/fuzzer+0x4438c3)
+    #3 0x7f57fba5751f  (/lib/x86_64-linux-gnu/libpthread.so.0+0x1351f)
+    #4 0x7f57fb74cf60 in raise (/lib/x86_64-linux-gnu/libc.so.6+0x39f60)
+    #5 0x7f57fb738534 in abort (/lib/x86_64-linux-gnu/libc.so.6+0x25534)
+    #6 0x4b84d5 in cmd_kill(IGdbTarget*, int, char const*) /usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/gdb.cpp:336:5
+    #7 0x4b88ea in gdb_serve(int, IGdbTarget*) /usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/gdb.cpp:379:26
+    #8 0x4b85c0 in RunGDB(IGdbTarget*, int) /usr/local/google/home/xuanxing/Source/WhiteChapel/gsa-rom/external/emu/ap-rom/gdb.cpp:423:9
+    #9 0x7f57fc5e296f  (/lib/x86_64-linux-gnu/libstdc++.so.6+0xce96f)
+    #10 0x7f57fba4cfb6 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x8fb6)
+    #11 0x7f57fb80d19e in clone (/lib/x86_64-linux-gnu/libc.so.6+0xfa19e)

src/python/tests/core/crash_analysis/stack_parsing/stack_analyzer_test.py

@@ -2867,3 +2867,29 @@ def test_python_unhandled_exception(self):
     self._validate_get_crash_data(data, expected_type, expected_address,
                                   expected_state, expected_stacktrace,
                                   expected_security_flag)
+
+  def test_gdb_sigtrap(self):
+    """Test for GDB stack."""
+    data = self._read_test_data('gdb_sigtrap.txt')
+    expected_type = 'SIGTRAP'
+    expected_address = '0x000000000ac8'
+    expected_state = (
+        'xymodem_trnasfer\nLoadImageFromUsb30\nLoadBL1FromUsb30\n')
+    expected_stacktrace = data
+    expected_security_flag = True
+    self._validate_get_crash_data(data, expected_type, expected_address,
+                                  expected_state, expected_stacktrace,
+                                  expected_security_flag)
+
+  def test_gdb_sigtrap_and_libfuzzer(self):
+    """Test for GDB stack with libfuzzer."""
+    data = self._read_test_data('gdb_sigtrap_and_libfuzzer.txt')
+    expected_type = 'SIGTRAP'
+    expected_address = '0x000000000ac8'
+    expected_state = (
+        'xymodem_trnasfer\nLoadImageFromUsb30\nLoadBL1FromUsb30\n')
+    expected_stacktrace = data
+    expected_security_flag = True
+    self._validate_get_crash_data(data, expected_type, expected_address,
+                                  expected_state, expected_stacktrace,
+                                  expected_security_flag)