Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iamKunalGupta/java-design-patterns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: iamKunalGupta/java-design-patterns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: MinorRefactorings
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 112 files changed
  • 1 contributor

Commits on Oct 17, 2018

  1. Made minor changes in some patterns such as removed throws clause whe… 

    …re not needed, changed incorrect order of arguments in assertEquals
    @npathai
    npathai committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    2f569d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2018

  1. Minor refactorings and code style changes. 1) Removed several use of … 

    …raw types 2) Removed unnecessary throws clauses 3) Used lambda expressions wherever applicable 4) Used apt assertion methods for readability 5) Use of try with resources wherever applicable 6) Corrected incorrect order of assertXXX arguments
    @npathai
    npathai committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    543eb9a View commit details
    Browse the repository at this point in the history

  2. Removed unused import from Promise

    @npathai
    npathai committed Oct 20, 2018
    Configuration menu
    Copy the full SHA
    70b4931 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Addressed review comments

    @npathai
    npathai committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    1017900 View commit details
    Browse the repository at this point in the history

  2. Addressed checkstyle issue

    @npathai
    npathai committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0fad8b9 View commit details
    Browse the repository at this point in the history
Loading