Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iamKunalGupta/java-design-patterns
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: iamKunalGupta/java-design-patterns
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: Issue#643
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Oct 15, 2018

  1. Resolves iluwatar#643, test cases failed due to presence of global st… 

    …ate in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.
    @npathai
    npathai committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    ced1dfe View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Updated class diagram png and added UCLS file

    @npathai
    npathai committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    0ed4747 View commit details
    Browse the repository at this point in the history
Loading