Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 0.1.0 #19

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Bump to version 0.1.0 #19

merged 1 commit into from
Oct 5, 2022

Conversation

ctmbl
Copy link
Contributor

@ctmbl ctmbl commented Oct 1, 2022

here is a PR for the first official version bump of the website.

Some questions must be address:

  • Where should the version go
    • 1️⃣ frontend/package.json and backend/package.json with same version (because for now there are developed at the same time)
    • 2️⃣ frontend/package.json, backend/package.json AND a root package.json indicating the version of the WHOLE website (the solution I chose in this PR ❤️ )
  • What should we do about the wrong tag v0.0.1 (I think we let it as it is and jump to next version)

The wiki will have be updated after this discussion
Right after this merging we will tag the commit with v0.1.0

HURRY UP this PR must be resolved before any other (especially #17) you have my point of view please give yours @atxr @amtoine

@ctmbl ctmbl requested review from atxr and amtoine October 1, 2022 06:30
@ctmbl ctmbl self-assigned this Oct 1, 2022
@ctmbl ctmbl added repo issue An issue that address the whole project/repo not a specific code feature Priority: High The Issue must be addressed as soon as possible Severity: Major The bug or Issue prevent a feature from working or present a possible security issue labels Oct 1, 2022
@atxr
Copy link
Contributor

atxr commented Oct 1, 2022

The second method you propose is definitely the good one for long term.
I think soon the backend and frontend development will be separated (for the best)
We should still be able to track the version of each one and release a global version for the website when needed.
So it's ok for me!
Just I think you forgot to add the version in frontend/package.json

@atxr
Copy link
Contributor

atxr commented Oct 1, 2022

Did you manage to find some documentation on removing an existing tag?

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR in itself looks good 👍

@amtoine
Copy link
Member

amtoine commented Oct 1, 2022

you should be able to simply

git tag --delete v0.0.1
git checkout 31e96b3
git tag v0.1.0 -m "blah blah"
git push --tags --prune

👍

Copy link
Contributor

@atxr atxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about frontend/package.json ?

@amtoine
Copy link
Member

amtoine commented Oct 4, 2022

What about frontend/package.json ?

in nushell, i get

nushell> [. frontend backend] | each {
  |it|
  open $"($it)/package.json" | get version
}
╭───┬───────╮
│ 0 │ 0.1.0 │
│ 1 │ 0.1.0 │
│ 2 │ 0.1.0 │
╰───┴───────╯

is there anything to do in frontend/package.json? 🤔

Copy link
Contributor

@atxr atxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes indeed, it's aleady the right version

@ctmbl ctmbl merged commit 1f30789 into main Oct 5, 2022
@ctmbl ctmbl deleted the version-bump branch October 5, 2022 00:42
@ctmbl ctmbl added this to the iScsc blog v0.0.1 milestone Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High The Issue must be addressed as soon as possible repo issue An issue that address the whole project/repo not a specific code feature Severity: Major The bug or Issue prevent a feature from working or present a possible security issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants