Skip to content

Fix Nav Launch detection related bugs #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avsaase merged 7 commits into from
Apr 12, 2021
Merged

Fix Nav Launch detection related bugs #6430

avsaase merged 7 commits into from
Apr 12, 2021

Conversation

@breadoven
Copy link
Collaborator

@breadoven breadoven commented Dec 17, 2020 •
edited
Loading

resolves #6427 and fixes:

  1. Redundant code in navigation_fw_launch.c deleted.
  2. Bug in rth_estimator.c - wouldn't have picked up launch aborted prior to launch detection (aborted with stick movement when Launch set as Feature). This change is required now anyway due to the changes to the Launch code for 2.6.0 and the way launch detection is flagged after launch.

@breadoven
Merge pull request #12 from iNavFlight/master
416670d 
Update Master
@breadoven
Merge pull request #13 from iNavFlight/master
0935d9c 
Update Master
@breadoven
Merge pull request #14 from iNavFlight/release_2.6.0
bbd826e 
Docs update for 2.6.0
@breadoven
Merge pull request #15 from iNavFlight/master
6e64b6f 
Update from INAVFlight master
@breadoven
Fix Nav Launch Related Errors
a1f9bbd 
Fixes:
Launch detection bug.
Repeated redundant code
RTH estimator bug - not detecting Nav launch aborted prior to launch detection
digitalentity
digitalentity reviewed Dec 18, 2020
View reviewed changes
@avsaase
Copy link
Member

avsaase commented Jan 9, 2021 •
edited
Loading

Is this ready to test?

@breadoven
Copy link
Collaborator Author

breadoven commented Jan 10, 2021

Well the changes fix the issue with the flight timer and the RTH estimator still works as before so it should work OK.

@breadoven
Update rth_estimator.c
49be352 
Remove white space
@breadoven breadoven mentioned this pull request Feb 11, 2021
Closed
This was referenced Feb 26, 2021
Merged
Closed
@avsaase
Copy link
Member

avsaase commented Apr 3, 2021 •
edited
Loading

closes #6427 (nope, this doesn't like the issue)

@breadoven
Copy link
Collaborator Author

breadoven commented Apr 3, 2021

Tried editing my original post @avsaase to auto close this but doesn't seem to work (I assume that's what you're trying to do).

Although at the moment this bug fix is yet to be approved together with a number of others. Would be useful to know why this is the case.

@avsaase
Copy link
Member

avsaase commented Apr 3, 2021

@breadoven It seems the issue is now properly linked. I was trying to do it using the linked issue menu on the right but I couldn't find the issue there.

I have flown with this PR for the past couple of months and all seems to work well, so I think this can be merged.

@avsaase avsaase requested a review from digitalentity April 3, 2021 13:35
@avsaase avsaase added this to the 3.0 milestone Apr 12, 2021
@avsaase avsaase merged commit d27adb1 into iNavFlight:master Apr 12, 2021
@breadoven breadoven deleted the aob_fix_launch_detection_logic branch April 13, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digitalentity digitalentity Awaiting requested review from digitalentity

Assignees

No one assigned

Labels

Ready to merge

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Flight timer doesn't start until auto launch sequence ends

3 participants

@breadoven @avsaase @digitalentity