-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Allow yaw to have negative expo #11098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Compliance Guide 🔍All compliance sections have been disabled in the configurations. |
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Explicit cast added
Fixed more casting
- Removed debug, oops - Tidied up the rcLookup function with a constrainf and lrintf
User description
There was a discussion in the INAV Discord fixed-wing channel regarding the rudder control in INAV, how it's underwhelming, and how boosting FF to 255 for yaw is not the best solution. The idea (from James Downing FPV) of having negative expo on the rudder was discussed. It seems like a sound concept and worth investigating. So this PR, along with the configurator counterpart, allows negative expo on the yaw axis.
Configurator iNavFlight/inav-configurator#2419
PR Type
Enhancement
Description
This description is generated by an AI tool. It may have inaccuracies
Enable negative expo values for yaw axis control
rcYawExpo8fromuint8_ttoint8_tin stabilized and manual modesRefactored RC curve calculation to support negative expo
rcLookup()function with new expo formulaapplyAdjustmentI8()for signed 8-bit adjustmentsUpdated MSP protocol handlers for signed yaw expo serialization
sbufWriteU8()tosbufWriteI8()for yaw expo transmissionsbufReadU8()tosbufReadI8()for yaw expo receptionAdded stream buffer support for signed 8-bit integers
Diagram Walkthrough
File Walkthrough
8 files
Add signed 8-bit write functionDeclare sbufWriteI8 function signatureChange yaw expo to signed integer typeUpdate axis command function parameterUse signed serialization for yaw expoAdd signed adjustment and yaw-specific handlingImplement new expo formula supporting negative valuesUpdate rcLookup function signature1 files
Update yaw expo min range documentation1 files
Extend yaw expo range to negative values