Implement version 2 of ext-idle-notify-v1 protocol #8959
+161
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coolio, the impl looks alright to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This is basically a counterpart to a similar draft merge request that I did for wlroots, one that is meant to implement a revision to the ext-idle-notify protocol described in this merge request to wayland-protocols here: wayland/wayland-protocols!367
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I did test this to make sure that it would work at least with my fork of Workrave.
Is it ready for merging, or does it need work?
This is a draft simply because the merge request for the wayland-protocols is still pending. Once it stops being pending, the commit "Temporarily allow build with w/o JJR fork of wayland-protocols" should be reverted. There is also the possibility that there will be further changes to the wayland-protocols merge request before it gets approved -- presuming of course that it gets approved at all.