-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Replace generateVersion.sh #12110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Replace generateVersion.sh #12110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion.h in helpers/MiscFunctions.cpp
nnra6864
added a commit
to nnra6864/hyprland-wiki
that referenced
this pull request
Oct 23, 2025
This is needed for hyprwm/Hyprland#12110
nnra6864
added a commit
to nnra6864/hyprland-wiki
that referenced
this pull request
Oct 23, 2025
This is needed for hyprwm/Hyprland#12110
vaxerski
approved these changes
Oct 23, 2025
Member
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
vaxerski
pushed a commit
to hyprwm/hyprland-wiki
that referenced
this pull request
Oct 23, 2025
This is needed for hyprwm/Hyprland#12110
nnra6864
added a commit
to nnra6864/hypr-dynamic-cursors
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
nnra6864
added a commit
to nnra6864/hy3
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
nnra6864
added a commit
to nnra6864/hyprgrass
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
nnra6864
added a commit
to nnra6864/hyprland-virtual-desktops
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
This was referenced Oct 23, 2025
nnra6864
added a commit
to nnra6864/hyprmodoro
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
nnra6864
added a commit
to nnra6864/hyprtoplr
that referenced
this pull request
Oct 23, 2025
This is needed since hyprwm/Hyprland#12110 got merged
Contributor
|
What about Hyprland/.github/workflows/release.yaml Line 22 in aa5a239
|
Member
|
@fufexan pls? |
fufexan
added a commit
that referenced
this pull request
Oct 26, 2025
outfoxxed
pushed a commit
to nnra6864/hy3
that referenced
this pull request
Nov 1, 2025
This is needed since hyprwm/Hyprland#12110 got merged
jazzpi
added a commit
to jazzpi/nixcfg
that referenced
this pull request
Nov 10, 2025
This reverts commit b8da4d9. Hy3 was broken due to hyprwm/Hyprland#12110, but this should be fixed with outfoxxed/hy3#247 being merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This PR replaces the
generateVersion.shscript withCMakeLists.txtandmeson.buildcode.This way,
versions.hheader will have all the correct versions set before the build.There should no longer be issues with plugins comparing versions against values such as
@AQUAMARINE_VERSION@, e.g.:Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This PR introduces a breaking change for plugins.
Each plugin must change this:
To this:
Is it ready for merging, or does it need work?
This should be ready for merging.
I tested both cmake and meson builds, and both were fine on my end.
A wiki PR is needed, as well as updates for each plugin.
I would like to give all the credit to @ItsOhen, he wrote pretty much all the code, and guided me all the way through this.