Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getfuncargvalue -> getfixturevalue #4959

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

seanh
Copy link
Contributor

@seanh seanh commented Apr 9, 2018

getfuncargvalue was deprecated in pytest 3.0.0:

* https://docs.pytest.org/en/latest/changelog.html?highlight=getfuncargvalue#id329
* pytest-dev/pytest#1626

The latest, which we use, is pytest 3.5.0.
@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #4959 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4959   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         397      397           
  Lines       22450    22450           
  Branches     1258     1258           
=======================================
  Hits        21717    21717           
  Misses        615      615           
  Partials      118      118
Impacted Files Coverage Δ
tests/h/views/activity_test.py 99.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea835f...3da238a. Read the comment docs.

@seanh seanh added Python 3 Issues related to making our code Python 3-compatible and removed Python 3 Issues related to making our code Python 3-compatible labels Apr 9, 2018
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertknight robertknight merged commit 48b4e0e into master Apr 10, 2018
@robertknight robertknight deleted the remove-getfuncargvalue branch April 10, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants