Skip to content

feat: using latest ubuntu runners #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

thugrock7
Copy link
Contributor

@thugrock7 thugrock7 commented Apr 22, 2025

Description:
Ubuntu 20.04 Actions runner image is deprecated as of 15th April 2025. So updating to use ubuntu-latest image
Ref: actions/runner-images#11101
SInce latest ubuntu image uses java 17 by default, updated to use JDK 11 to build and test to keep things as it is

@@ -42,3 +42,5 @@ jobs:
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain --stacktrace -Ptag=$TAG
./gradlew jib -PtargetJDK=15 -Djib.httpTimeout=120000 -Djib.console=plain --stacktrace -Ptag=$TAG
working-directory: smoke-tests/springboot
env:
JVM_OPTS: -Xmx1g --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these java options for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --add-opens flags were added because Java 17 (default in ubuntu-latest) strictly blocks reflection access that was permitted in Java 11.
Ref actions: https://github.com/hypertrace/javaagent/actions/runs/14587461988/job/40915439308
To solve InaccessibleObjectException observed, explicitly granting permission to use reflection on Java's internal classes of java.util and java.io packages

@thugrock7 thugrock7 merged commit 3696821 into hypertrace:main Apr 22, 2025
10 of 11 checks passed
@thugrock7 thugrock7 deleted the runners-fix branch April 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants