Skip to content

feat: update angular #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2020
Merged

feat: update angular #109

merged 3 commits into from
Nov 28, 2020

Conversation

aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Nov 26, 2020

Description

Angular major version upgrade

Testing

Built and ran locally, as well as the existing unit tests/CI

Checklist:

  • My changes generate no new warnings - there are actually some new deprecations that should be addressed separately
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #109 (97835f2) into main (f975d2e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #109   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines          651       651           
  Branches        59        59           
=========================================
  Hits           651       651           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f975d2e...97835f2. Read the comment docs.

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review November 26, 2020 13:06
@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner November 26, 2020 13:06
@anandtiwary
Copy link
Contributor

Can we update Peer dependencies as well?

@aaron-steinfeld
Copy link
Contributor Author

Can we update Peer dependencies as well?

whoops thought ng update did that. updated.

@aaron-steinfeld aaron-steinfeld merged commit f2fd97c into main Nov 28, 2020
@aaron-steinfeld aaron-steinfeld deleted the update-ng branch November 28, 2020 16:56
@hypertrace-ci
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants