Skip to content

fix: add validation for nested_format in Querystring #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add validation for nested_format in Querystring #102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/hyperspell/_qs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,26 @@ def _stringify_item(
if isinstance(value, Mapping):
items: list[tuple[str, str]] = []
nested_format = opts.nested_format

if nested_format not in get_args(NestedFormat):
raise ValueError(
f"Unknown nested_format value: {nested_format}, "
f"choose from {', '.join(get_args(NestedFormat))}"
)

for subkey, subvalue in value.items():
if nested_format == "dots":
new_key = f"{key}.{subkey}"
elif nested_format == "brackets":
new_key = f"{key}[{subkey}]"
else:
# This should be unreachable due to the check above
# but kept for type safety and future-proofing
raise ValueError(f"Unhandled nested_format: {nested_format}")

items.extend(
self._stringify_item(
# TODO: error if unknown format
f"{key}.{subkey}" if nested_format == "dots" else f"{key}[{subkey}]",
new_key,
subvalue,
opts,
)
Expand Down