Feature/readme #86
Merged
Feature/readme #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| To start your slideshow just instantiate `LightboxController`, set needed | ||
| delegates and present it: | ||
|
|
zenangst
reviewed
Dec 19, 2016
|
|
||
| ### Image loading | ||
|
|
||
| Bu default images are loaded using `sendAsynchronousRequest` method of |
There was a problem hiding this comment.
@vadymmarkov what do you mean with Bu ? :)
zenangst
reviewed
Dec 19, 2016
| ### Configuration | ||
|
|
||
| Configure text, colors, fonts of UI elements by just overriding the static | ||
| variables in the **Lightbox** [configuration](https://github.com/hyperoslo/Lightbox/blob/master/Source/LightboxConfig.swift) struct. As an example: |
There was a problem hiding this comment.
I would change:
Configure text, colors, fonts of UI elements by just overriding the static
variables in the **Lightbox**
To:
Configure text, colors, fonts of UI elements by overriding the static
variables in the **Lightbox**
Just remove just (pun intended)
zenangst
reviewed
Dec 19, 2016
| - [x] Video support. | ||
| - [x] Double-tap to zoom. | ||
| - [x] Image caption. | ||
| - [x] Dynamic background. |
There was a problem hiding this comment.
Should we describe what Dynamic background is? Or is that clear enough in itself?
There was a problem hiding this comment.
Could you write a few words about it so I will add? 😄
There was a problem hiding this comment.
We don't go into detail on anything else so we can just leave it 😁
|
@vadymmarkov this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.