Fixed AsyncStorage exists not throwing errors#325
Open
kitwtnb wants to merge 3 commits intohyperoslo:masterfrom
Open
Fixed AsyncStorage exists not throwing errors#325kitwtnb wants to merge 3 commits intohyperoslo:masterfrom
exists not throwing errors#325kitwtnb wants to merge 3 commits intohyperoslo:masterfrom
Conversation
Collaborator
|
Hi @kitwtnb, Would you be so kind on adding a tests that reproduces the error as well to avoid regressions? |
Contributor
Author
|
Changed Do I need to test separately from these? |
Collaborator
|
Can anyone else verify if this breaks anything for them? |
Contributor
Author
|
I understand what you are trying to say. This test originally reproduced the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
existsObject()returns true or throw error, not returning false.As per StorageAware,
existsObject()should not throw an error.Fix
existsObject()to return false instead of error.