Fix benchmark artifact names in release job #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
added
kind/enhancement
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
benchmarks_artifact_name
branch
from
21a3f87 to
6dbc3d5
Compare
|
how exactly did this break? |
marosset
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the tarfiles of our benchmarking artifacts to match the ones that we create. When switching to linux runners in #370, this became a hard-errror: https://github.com/hyperlight-dev/hyperlight/actions/runs/13954211641/job/39062218141.
This was broken even with the windows runner, but was manifesting as empty benchmark files on our github release page