Review/remove and prevent unintentional use of expect/assert*/panic/unwrap in hyperlight_host and hyperlght_common
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/refactor
simongdavies
force-pushed
the
fix-unwrap-panic-expect-assert
branch
3 times, most recently
from
8f6ad7f to
5d4faf5
Compare
simongdavies
force-pushed
the
fix-unwrap-panic-expect-assert
branch
4 times, most recently
from
e1c5ad9 to
b7dab3c
Compare
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-unwrap-panic-expect-assert
branch
from
b7dab3c to
e8e9bd6
Compare
simongdavies
changed the title
expect/assert*/panic/unwrap in hyperlightexpect/assert*/panic/unwrap in hyperlight_host
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-unwrap-panic-expect-assert
branch
from
e8e9bd6 to
1716a9a
Compare
simongdavies
changed the title
expect/assert*/panic/unwrap in hyperlight_hostexpect/assert*/panic/unwrap in hyperlight_host
simongdavies
changed the title
expect/assert*/panic/unwrap in hyperlight_hostexpect/assert*/panic/unwrap in hyperlight_host
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
changed the title
expect/assert*/panic/unwrap in hyperlight_hostexpect/assert*/panic/unwrap in hyperlight_host and hyperlght_common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a clippy lints to check for use of expect, panic and unwrap in hyperlight-host for non test/non dev code in hyperlight_host and hyperlight_common
Removes all uses of expect in non test/dev code in hyperlight-host.
Removes all uses of panic in non test/dev code in hyperlight-host.
Removes all uses of unwrap in non test/dev code in hyperlight-host.
Adds a clippy.toml file to hyperlight_host/src and hyperlight_common/src to prevent the use of assert* using disallowed_macros lint
Disables the disallowed_macros lint for test and dev code
Fixes #320