Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic guest/host result API #259

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Feb 12, 2025

Makes get_flatbuffer_result and get_host_value_return_as generic, see 2 commits.

@ludfjig ludfjig added the kind/refactor For PRs that restructure or remove code without adding new functionality. label Feb 12, 2025
@ludfjig ludfjig force-pushed the generic_guest_result branch 2 times, most recently from b81bbc8 to 882685c Compare February 12, 2025 23:06
@ludfjig ludfjig force-pushed the generic_guest_result branch 3 times, most recently from 5b64653 to 1ac6c2f Compare February 20, 2025 23:44
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig force-pushed the generic_guest_result branch from 1ac6c2f to 9553f86 Compare February 27, 2025 19:41
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Copy link
Contributor

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ludfjig ludfjig merged commit 137457c into hyperlight-dev:main Feb 28, 2025
21 checks passed
myadav27 pushed a commit to myadav27/hyperlight that referenced this pull request Mar 4, 2025
* Make `get_flatbuffer_result` generic

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>

* Make `get_host_value_return_as` generic

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>

* fix broken rebase

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>

---------

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Manoj Kumar Yadav <myadav27@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants