-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic guest/host result API #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b81bbc8
to
882685c
Compare
simongdavies
requested changes
Feb 17, 2025
5b64653
to
1ac6c2f
Compare
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
1ac6c2f
to
9553f86
Compare
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
devigned
approved these changes
Feb 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
simongdavies
approved these changes
Feb 27, 2025
dblnz
approved these changes
Feb 28, 2025
myadav27
pushed a commit
to myadav27/hyperlight
that referenced
this pull request
Mar 4, 2025
* Make `get_flatbuffer_result` generic Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> * Make `get_host_value_return_as` generic Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> * fix broken rebase Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> --------- Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> Signed-off-by: Manoj Kumar Yadav <myadav27@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
get_flatbuffer_result
andget_host_value_return_as
generic, see 2 commits.