Run clippy on guests in CI #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
clippy_guests
branch
2 times, most recently
from
4be0e64 to
3a1be12
Compare
marosset
reviewed
Feb 5, 2025
ludfjig
force-pushed
the
clippy_guests
branch
from
fa3374b to
17e42fe
Compare
|
Related to the change from i64 -> usize #216 |
simongdavies
previously approved these changes
Feb 6, 2025
ludfjig
force-pushed
the
clippy_guests
branch
from
7366393 to
4236017
Compare
ludfjig
force-pushed
the
clippy_guests
branch
from
4236017 to
9a91e7e
Compare
marosset
previously approved these changes
Feb 28, 2025
dblnz
previously approved these changes
Feb 28, 2025
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
clippy_guests
branch
from
f5a248b to
d8c24e5
Compare
marosset
approved these changes
Feb 28, 2025
myadav27
pushed a commit
to myadav27/hyperlight
that referenced
this pull request
Mar 4, 2025
* Clippy guests Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> * Add matrix target to recipe Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> * fix broken rebase Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> --------- Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com> Signed-off-by: Manoj Kumar Yadav <myadav27@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217 by running cargo clippy on the guests in CI. Also fixes existing clippy violations that have snuck in. Note that the change from i64->usize is a breaking change
also closes #216