Fix issues with using CreateMapViewOfFile with inprocess feature
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I think they are new failures, hopefully fixed now |
simongdavies
force-pushed
the
fix-memory-map
branch
from
0a8e76e to
adee60a
Compare
simongdavies
force-pushed
the
fix-memory-map
branch
from
d10fe20 to
2ee6459
Compare
ludfjig
previously approved these changes
Feb 4, 2025
simongdavies
force-pushed
the
fix-memory-map
branch
2 times, most recently
from
961b8f5 to
9f22e6a
Compare
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-memory-map
branch
from
9fb6c41 to
df56959
Compare
marosset
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#135 introduced a change to the way memory is allocated and shared with surrogate process on Windows, this change causes failures when the
inprocessfeature is enabled , tests failed but did not trigger CI failures because of #138 .This PR fixes that issue.