Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Musl subtree #104

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Musl subtree #104

merged 6 commits into from
Dec 19, 2024

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Dec 10, 2024 •
edited
Loading

Adds musl as a git subtree. Adds more of libc, as required by for example a quickjs guest.

The 6 commits does the following

  1. Removes current musl
  2. Adds musl v1.2.5 (latest) as a git subtree (squashed)
  3. Merge commit for git subtree
  4. Removes musl files we don't need
  5. Patches musl for Hyperlight
  6. Updates docs/build.rs/justfiles

[having some problems gpg signing the squash commit...]

@ludfjig ludfjig mentioned this pull request Dec 10, 2024
Closed
@ludfjig ludfjig added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Dec 10, 2024
@ludfjig ludfjig force-pushed the musl_subtree branch 9 times, most recently from d07b31f to 1c4344b Compare December 11, 2024 19:20
@ludfjig ludfjig marked this pull request as ready for review December 11, 2024 20:54
@ludfjig ludfjig mentioned this pull request Dec 11, 2024
Merged
@hyperlight-dev hyperlight-dev deleted a comment from hyperlight-prow bot Dec 17, 2024
marosset
marosset approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I mostly just reviewed 6fa239e)

simongdavies
simongdavies approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@ludfjig ludfjig force-pushed the musl_subtree branch 2 times, most recently from 89a5969 to 99e9bc5 Compare December 17, 2024 22:31
@ludfjig
Remove old musl from repo to be replaced by git subtree
7f89254 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig force-pushed the musl_subtree branch 5 times, most recently from 3e68f7f to d0b3095 Compare December 19, 2024 20:12
@ludfjig
Squashed 'src/hyperlight_guest/third_party/musl/' content from commit…
667589a 
… 0784374d5

git-subtree-dir: src/hyperlight_guest/third_party/musl
git-subtree-split: 0784374d561435f7c787a555aeab8ede699ed298
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
Merge commit '667589ab525fef0f2ce16815084fb22196a35c73' as 'src/hyper…
1ef5e2a 
…light_guest/third_party/musl'

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
Remove musl files we don't need
c604b99 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
Patch musl for Hyperlight
42ee008 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
Update justfiles, build.rs and readme for musl subtree
e79ec96 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig merged commit e79ec96 into hyperlight-dev:main Dec 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simongdavies simongdavies simongdavies approved these changes

@marosset marosset marosset approved these changes

@syntactically syntactically Awaiting requested review from syntactically

Assignees
No one assigned
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludfjig @simongdavies @marosset