Skip to content

Commit 8cec8c0

Browse files
remove .vscode settings (#66)
* remove .vscode settings Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * additional changes and addressing feedback Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * Update .devcontainer/Dockerfile Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com> Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> --------- Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> Co-authored-by: Dan Chiarlone <danilochiarlone@gmail.com>
1 parent d771dea commit 8cec8c0

File tree

6 files changed

+12
-78
lines changed

6 files changed

+12
-78
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,6 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
5959
&& rustup target add x86_64-unknown-linux-gnu \
6060
&& rustup target add x86_64-unknown-none \
6161
&& rustup target add x86_64-pc-windows-msvc \
62+
&& rustup toolchain add nightly-x86_64-unknown-linux-gnu \
6263
&& cargo install just
6364

.devcontainer/devcontainer.json

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@
2727
"ms-vscode.cmake-tools",
2828
"rust-lang.rust-analyzer",
2929
"vadimcn.vscode-lldb"
30-
]
30+
],
31+
"settings": {
32+
"rust-analyzer.rustfmt.extraArgs": [
33+
"+nightly" // required for rustfmt.toml which uses nightly features
34+
]
35+
}
3136
}
3237
}
3338
}

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -448,10 +448,6 @@ $RECYCLE.BIN/
448448
## Visual Studio Code
449449
##
450450
.vscode/*
451-
!.vscode/settings.json
452-
!.vscode/tasks.json
453-
!.vscode/launch.json
454-
!.vscode/extensions.json
455451

456452
/downloads
457453

.vscode/launch.json

Lines changed: 0 additions & 50 deletions
This file was deleted.

.vscode/settings.json

Lines changed: 0 additions & 23 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ All contributions come through pull requests. To submit a proposed change, we re
3838
#### Use work-in-progress PRs for early feedback
3939

4040
A good way to communicate before investing too much time is to create a "Work-in-progress" PR and share it with your reviewers. The standard way of doing this is to add a "[WIP]" prefix in your PR's title and open the pull request as a draft.
41+
4142
### Developer Certificate of Origin: Signing your work
4243

4344
#### Every commit needs to be signed
@@ -82,3 +83,7 @@ git push --force-with-lease <remote-name> <branch-name>
8283
```
8384

8485
*Credit: This doc was cribbed from Dapr.*
86+
87+
### Rust Analyzer
88+
89+
If you are using the [Rust Analyzer](https://rust-analyzer.github.io/manual.html) then you may need to set the configuration option `rust-analyzer.rustfmt.extraArgs` to `["+nightly"]` to ensure that formatting works correctly as this project has a [`rustfmt.toml`](./rustfmt.toml) file that uses nightly features.

0 commit comments

Comments
 (0)