Reset more vcpu state on snapshot restore

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

Author: ludfjig

.github/workflows/ValidatePullRequest.yml

@@ -67,7 +67,7 @@ jobs:
       - docs-pr
       - build-guests
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
         hypervisor: [hyperv, 'hyperv-ws2025', mshv3, kvm]
         cpu: [amd, intel]

Cargo.lock

@@ -84,6 +84,7 @@ mshv-ioctls = { version = "0.6", optional = true}
 uuid = { version = "1.20.0", features = ["v4"] }
 signal-hook-registry = "1.4.8"
 serde = "1.0"
+iced-x86 = { version = "1.21", default-features = false, features = ["std", "code_asm"] }
 proptest = "1.9.0"
 tempfile = "3.24.0"
 crossbeam-queue = "0.3.12"

src/hyperlight_host/Cargo.toml

@@ -326,7 +326,11 @@ impl HyperlightError {
             | HyperlightError::StackOverflow()
             | HyperlightError::MemoryAccessViolation(_, _, _)
             | HyperlightError::SnapshotSizeMismatch(_, _)
-            | HyperlightError::MemoryRegionSizeMismatch(_, _, _) => true,
+            | HyperlightError::MemoryRegionSizeMismatch(_, _, _)
+            // HyperlightVmError::Restore doesn't technically need to poison the sandbox,
+            // because if MultiUseSandbox::restore() fails, the sandbox is still in the same
+            // poisoned state as before.
+            | HyperlightError::HyperlightVmError(HyperlightVmError::Restore(_)) => true,
 
             // HyperlightVmError::DispatchGuestCall may poison the sandbox
             HyperlightError::HyperlightVmError(HyperlightVmError::DispatchGuestCall(e)) => {