Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: how to represent parameters in genesis #4813

Open
Erigara opened this issue Jul 8, 2024 · 4 comments · May be fixed by #5020
Open

refactor: how to represent parameters in genesis #4813

Erigara opened this issue Jul 8, 2024 · 4 comments · May be fixed by #5020
Assignees
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers

Comments

@Erigara
Copy link
Contributor

Erigara commented Jul 8, 2024

I would like for parameters to look like this:

  "parameters": [
    {
      "sumeragi": {
        "block_time_ms": 2000
        "commit_time_ms": 4000
      }
    },
    {
      "block": {
        "max_transactions": 512
      }
    },
    {
      "transaction": {
        "max_instructions": 4096
        "smart_contract_size": 4194304
      }
    },
    {
      "executor": {
        "fuel": 55000000
        "memory": 55000000
      }
    },
    {
      "smart_contract": {
        "fuel": 55000000
        "memory": 55000000
      }
    }

Originally posted by @mversic in #4812 (comment)

@mversic mversic added good first issue Good for newcomers api-changes Changes in the API for client libraries labels Jul 8, 2024
@divyaranjan1905
Copy link

@Erigara Just to be sure, you're asking for iroha_data_model::parameter to be refactored into the above? Or, something else to be refactored in genesis' lib.rs?

@mversic
Copy link
Contributor

mversic commented Aug 12, 2024

in genesis/src.lib.rs

@dima74 dima74 self-assigned this Aug 28, 2024
@Mingela
Copy link
Contributor

Mingela commented Aug 29, 2024

Is it going to be reflected in the schema somehow? Would be great to see a proposal for that before merging the change.

@dima74 dima74 linked a pull request Aug 29, 2024 that will close this issue
3 tasks
@dima74
Copy link
Contributor

dima74 commented Aug 29, 2024

Is it going to be reflected in the schema somehow? Would be great to see a proposal for that before merging the change.

Yes, there is type RawGenesisTransaction in the schema, it will be changed accordingly (#5020 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants