Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing validation of transactions inside WASM #4803

Closed
dima74 opened this issue Jul 4, 2024 · 0 comments · Fixed by #4995
Closed

Consider removing validation of transactions inside WASM #4803

dima74 opened this issue Jul 4, 2024 · 0 comments · Fixed by #4995
Assignees
Labels
good first issue Good for newcomers Optimization Something isn't working as well as it should question Further information is requested

Comments

@dima74
Copy link
Contributor

dima74 commented Jul 4, 2024

Do we need to validate transactions inside WASM? Potentially validation on the host should be enough and validation at WASM side could be removed as a small perofrmance optimization.

One option I can think of is to make SignedTransaction validation #[cfg(not(target_family = "wasm"))]

I like this suggestion. Can we say that since data model entities are always provided by the host there is no need to validate them on the wasm side? If so, we can can open a ticket to generalize this approach to all entities, although it seems kinda hacky and I'm not sure if this won't bite us in the ass

Originally posted by @mversic in #4793 (comment)

@mversic mversic added good first issue Good for newcomers question Further information is requested Optimization Something isn't working as well as it should labels Jul 4, 2024
@dima74 dima74 self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Optimization Something isn't working as well as it should question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants