Skip to content

Conversation

@alex-semenyuk
Copy link
Member

@alex-semenyuk alex-semenyuk commented Feb 28, 2025

Proposed changes

Remove confusing point from pull request template

My Pull Request title is in format < issue name > eg Added links in the documentation.

It was taken from pull_request_template.md. It might mean that the name of issue and fix should be same, but it sounds confusing and useless


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
@alex-semenyuk alex-semenyuk requested a review from a team as a code owner February 28, 2025 20:28
@alex-semenyuk alex-semenyuk changed the title Remove useless point from pull request template Remove confusing point from pull request template Feb 28, 2025
@EnriqueL8
Copy link
Contributor

@alex-semenyuk
Copy link
Member Author

@EnriqueL8 Actually this PR is addressed exact this, so removed the point mentioned there

@EnriqueL8 EnriqueL8 merged commit a69f6e1 into hyperledger:main Mar 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants