Skip to content

Conversation

@alex-semenyuk
Copy link
Member

Proposed changes

Fix the following scorecard issues
https://github.com/alex-semenyuk/firefly/security/code-scanning/43
https://github.com/alex-semenyuk/firefly/security/code-scanning/42
https://github.com/alex-semenyuk/firefly/security/code-scanning/41
https://github.com/alex-semenyuk/firefly/security/code-scanning/40

The main reason is
Set any required write permissions at the job-level

So put packages: write under jobs, suppose for go.yml we don't need write


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
Signed-off-by: alexey semenyuk <alexsemenyuk88@gmail.com>
@alex-semenyuk alex-semenyuk requested a review from a team as a code owner February 17, 2025 08:36
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@EnriqueL8 EnriqueL8 merged commit 9a7e17d into hyperledger:main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants