use trivy ECR DB #1596
Merged
use trivy ECR DB #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should avoid 429 we were seeing from ghcr Signed-off-by: Alex Shorsher <alex.shorsher@kaleido.io>
shorsher
force-pushed
the
trivy-ecr-pull
branch
from
edbfe46 to
bca70ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
===========================================
- Coverage 100.00% 99.96% -0.04%
===========================================
Files 337 337
Lines 24230 29492 +5262
===========================================
+ Hits 24230 29483 +5253
- Misses 0 7 +7
- Partials 0 2 +2 ☔ View full report in Codecov by Sentry. |
EnriqueL8
approved these changes
Nov 1, 2024
Contributor
EnriqueL8
left a comment
EnriqueL8
left a comment
There was a problem hiding this comment.
Thank you, this is great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aqua security (trivy maintainers) now publish their vulnerability databases on ECR, which does not have rate limits. Using ECR should fix the 429 we were seeing when pulling from the default ghcr database that the trivy tool has built-in.