Skip to content

Conversation

@matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Sep 13, 2024

This pulls in a fix in firefly-common related to large number handling, and updates the other related dependencies and manifest list

Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
@matthew1001 matthew1001 requested a review from a team as a code owner September 13, 2024 15:03
"sha": "11a782c778227d198c0bff2fc94ad7e52ceea5a9994728ba05e781541680c32d"
},
"fabconnect": {
"image": "ghcr.io/hyperledger/firefly-fabconnect",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to update common here? I bet it has the same problem with JSON Numbers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think common is in the manifest list?

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update FabConnect and Tezos Connect to latest transaction manager as well?

@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (f0cdcff) to head (6fe5adf).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         338      338           
  Lines       24223    24223           
=======================================
  Hits        24164    24164           
  Misses         58       58           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthew1001
Copy link
Contributor Author

Don't we need to update FabConnect and Tezos Connect to latest transaction manager as well?

Yes to tezos - I'll do that now. Fabconnect doesn't pull in fftm I don't believe?

@EnriqueL8
Copy link
Contributor

Going to update the manifest with Tezos and Fabric at another point when we release a new rc

@EnriqueL8 EnriqueL8 merged commit 5bbc36d into hyperledger:main Sep 13, 2024
@EnriqueL8 EnriqueL8 deleted the update-ff-deps branch September 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants