-
Notifications
You must be signed in to change notification settings - Fork 238
chore: Ignore markdown files and GitHub workflows in Docker and Go wo… #1565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| paths-ignore: | ||
| - '**.md' | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason to limit the tests to only run when a PR is opened against the main branch. Removing this restriction will enable the development of feature branches and opening PRs against them.
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the test to run for these
| func TestCheckGeneratedMarkdownPages(t *testing.T) { |
1024f7b to
e873d29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 325 325
Lines 24049 24055 +6
=========================================
+ Hits 24049 24055 +6 ☔ View full report in Codecov by Sentry. |
…rkflows Signed-off-by: dwertent <david.wertenteil@kaleido.io>
e873d29 to
f5bd4a4
Compare
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't finish my previous review that we discussed
.github/workflows/go.yml
Outdated
| push: | ||
| branches: [main] | ||
| paths-ignore: | ||
| - '**.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this line as we want the tests to run to verify the reference
- 'doc-site/docs/reference/**.md' # include markdown files that are auto generated and need to be tested
EnriqueL8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This will prevent unnecessary tests from running when changes are made to the markdown files.
Here is an example: https://github.com/hyperledger/firefly/actions/runs/10594695480